Re: [PATCH v3 3/3] platform: lenovo: wmi-fn-keys: ignore the keyboard backlight level events
From: Rong Zhang
Date: Sat Nov 21 2026 - 05:50:50 EST
Hi David,
Thanks for your work.
On Fri, 2026-11-20 at 19:33 -0800, David Cemin wrote:
> The Yoga 9 2-in-1 16 reports the keyboard backlight level selected with
> Fn+Space on the Fn key event GUID: 0x40 for off, 0x41 for low, 0x42 for
> high, and 0x43 was seen once while cycling. The firmware changes the
> backlight itself, so these events carry no action for the OS; add them
> as KE_IGNORE entries so they stop being logged as unknown key codes.
>
> Signed-off-by: David Cemin <dcemin@xxxxxxxxxx>
> ---
> drivers/platform/lenovo/wmi-fn-keys.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/lenovo/wmi-fn-keys.c b/drivers/platform/lenovo/wmi-fn-keys.c
> index 330de9529a87..21d36e798ba5 100644
> --- a/drivers/platform/lenovo/wmi-fn-keys.c
> +++ b/drivers/platform/lenovo/wmi-fn-keys.c
> @@ -108,6 +108,14 @@ static const struct key_entry lwmi_fn_keys_keymap[] = {
> { KE_KEY, 0x2d | LWMI_FN_KEY, { KEY_SELECTIVE_SCREENSHOT } },
> { KE_KEY, 0x29 | LWMI_FN_KEY, { KEY_TOUCHPAD_TOGGLE } },
> { KE_KEY, 0x2a | LWMI_FN_KEY, { KEY_ROOT_MENU } },
> + /*
> + * Keyboard backlight level after Fn+Space, handled by the firmware:
> + * 0x40 off, 0x41 low, 0x42 high
> + */
> + { KE_IGNORE, 0x40 | LWMI_FN_KEY },
> + { KE_IGNORE, 0x41 | LWMI_FN_KEY },
> + { KE_IGNORE, 0x42 | LWMI_FN_KEY },
> + { KE_IGNORE, 0x43 | LWMI_FN_KEY },
Could you please place all KE_IGNORE entries together? I.e., following
0x03.
With it fixed, the patch looks good to me:
Reviewed-by: Rong Zhang <i@xxxxxxxx>
Thanks,
Rong
>
> /*
> * WMI switches