Re: [PATCH v3 00/11] leds: class: Support custom sysfs groups on multicolor and flash LEDs
From: Rong Zhang
Date: Sat Nov 21 2026 - 06:26:30 EST
Hi Armin,
On Fri, 2026-11-20 at 22:22 +0100, Armin Wolf wrote:
> Until now drivers are unable to atomically register custom sysfs
> groups below multicolor and flash LED class devices, because the
> led_cdev->sysfs_groups field is being overwritten inside the
> associated initialization functions. This patch series tries to
> fix this.
>
> The first three patches constify the sysfs attributes of all three
> LED flavors, while the next four patches fix various unrelated issues
> affecting LED device initialization. The next two patches migrate
> the multicolor and flash LEDs to use struct device_type for
> registering their sysfs attributes, so that led_cdev->sysfs_groups is
> not touched anymore. The last patch contains a minor optimization
> for multicolor LEDs.
>
> All patches have been tested on real hardware, with the flash LED
> interface being tested using a custom kernel module.
The series looks good to me (except for PATCH 10, as I am not familiar
with that driver).
FWIW, for PATCH 1-9,11:
Reviewed-by: Rong Zhang <i@xxxxxxxx>
Thanks,
Rong
>
> Changes since v2:
> - fix issue inside KTD202X driver
>
> Changes since v1:
> - use READ_ONCE() inside brightness_hw_changed_show()
> - fix possible deadlock in led_classdev_notify_brightness_hw_changed()
> - set led_cdev->dev to NULL when initialization fails
> - call device_set_node() after device_add()
>
> Armin Wolf (11):
> leds: class: Constify sysfs attributes
> leds: multicolor: Constify sysfs attributes
> leds: flash: Constify sysfs attributes
> leds: class: Create "brightness_hw_changed" attribute atomically
> leds: class: Fix race condition when creating the device
> leds: class: Access brightness_hw_changed exactly once
> leds: class: Use correct type for brightness_hw_changed field
> leds: class: Split led_classdev_register_ext()
> leds: Support custom sysfs groups on multicolor and flash LEDs
> leds: rgb: ktd202x: Initialize max_brightness before registering LED
> leds: multicolor: Adjust maximum subled intensity during
> initialization
>
> drivers/leds/led-class-flash.c | 153 +++++++++---------
> drivers/leds/led-class-multicolor.c | 76 ++++-----
> drivers/leds/led-class.c | 233 +++++++++++++++++++---------
> drivers/leds/leds.h | 3 +
> drivers/leds/rgb/leds-ktd202x.c | 4 +-
> include/linux/led-class-flash.h | 5 -
> include/linux/leds.h | 2 +-
> 7 files changed, 278 insertions(+), 198 deletions(-)