Re: [v4 0/3] block: delay support for error injection

From: Haris Iqbal

Date: Sat Nov 21 2026 - 06:27:55 EST




On 11/20/26 17:44, Christoph Hellwig wrote:
On Wed, Nov 18, 2026 at 09:07:49AM -0700, Jens Axboe wrote:

On Wed, 11 Nov 2026 22:58:35 +0100, Md Haris Iqbal wrote:
Error injection can only fail a bio today. This adds a delay_us option so
that a rule can hold a bio back first, to model a slow device. The delay
happens above the driver, so it tests the code waiting above the block
layer, not the blk-mq timeout handler.

A delayed bio is marked with a new BIO_ERROR_INJECTED flag so the rules
are not applied to it again, even after a split. Christoph asked on v2
to avoid the flag by allowing a delay only together with an error. I kept
delay-only rules, as a slow device that succeeds is the more useful case,
so the flag question is still open.

[...]

Applied, thanks!


Hmm. This still has rela issues as pointed out by Sashiko. I'd very
much expect a resend to address them.

I can resend with the fix, or send just the fix to be patched above this, since these are already picked. Let me know whats preferable.