Re: [PATCH v12 2/4] soc: qcom: add core driver for the Qualcomm Crypto Engine
From: Krzysztof Kozlowski
Date: Sat Nov 21 2026 - 06:32:49 EST
On 20/11/2026 20:34, Bartosz Golaszewski wrote:
> Add the core driver for the Qualcomm crypto engine. Its task is to bind
> to the qce DT node, set up runtime PM for interconnect down-scaling and
> register the auxiliary device using the crypto offloader driver.
I dislike the "core driver" in the commit msg and subject. It suggests
there is some core feature or core stuff, but that's not true. You are
adding STUB driver only to handle Linux RPM things (which have impact on
interconnects, of course).
The Kconfig has it nicely explained, but here I see it as confusing.
>
> Tested-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> Tested-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx>
> Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
> drivers/soc/qcom/Kconfig | 11 ++++++
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/qce-core.c | 92 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 104 insertions(+)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 535c8619197b3e889e536da072ab89d3bb729804..67d54d5211ff21bae77cd8408fa47af630060949 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -121,6 +121,17 @@ config QCOM_PMIC_GLINK
> Say yes here to support USB-C and battery status on modern Qualcomm
> platforms.
>
...
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Qualcomm crypto engine core driver");
> +MODULE_ALIAS("platform:" KBUILD_MODNAME);
You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.
> +MODULE_AUTHOR("Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>");
>
Best regards,
Krzysztof