Re: [PATCH ath-next v3 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575
From: Krzysztof Kozlowski
Date: Sat Nov 21 2026 - 07:31:19 EST
On Wed, Nov 18, 2026 at 01:45:29PM +0530, Madhavan Ganesan wrote:
> +int ath12k_wifi8_hw_init(struct ath12k_base *ab)
> +{
> + const struct ath12k_hw_params *hw_params = NULL;
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(ath12k_wifi8_hw_params); i++) {
> + hw_params = &ath12k_wifi8_hw_params[i];
> +
> + if (hw_params->hw_rev == ab->hw_rev)
> + break;
> + }
> +
> + if (i == ARRAY_SIZE(ath12k_wifi8_hw_params)) {
> + ath12k_err(ab, "Unsupported Wi-Fi 8 hardware version: 0x%x\n",
> + ab->hw_rev);
> + return -EINVAL;
> + }
> +
> + ab->hw_params = hw_params;
> +
> + ath12k_info(ab, "Wi-Fi 8 Hardware name: %s\n", ab->hw_params->name);
Drivers should be silent on success (see coding style doc). This is not
even called anywhere, so difficult to follow any logic here how is this
supposed to be used, e.g. if this is initcall then clearly NAK.
Organize your work in logical chunks instead of adding bunch of
functions without users.
Best regards,
Krzysztof