Re: [PATCH v2 1/3] mm/ksm: do not inherit ksm_zero_pages counter or PTE markers on fork
From: David Hildenbrand (Arm)
Date: Sat Nov 21 2026 - 07:58:34 EST
On 11/20/26 08:43, Xu Xin (vivo) wrote:
> As documented in Documentation/admin-guide/mm/ksm.rst, ksm_zero_pages
> accounts only for zero pages actually placed by KSM. However, the
> current implementation wrongly accounts for forked zero-page PTEs as
> KSM's contribution, inflating both the child's per-mm counter and the
> global ksm_zero_pages counter.
>
> Originally, commit e2942062e01d ("ksm: count all zero pages placed by
> KSM") marked KSM-placed zero-page PTEs with the dirty bit for unmap
> accounting, but forgot to clear this marker during fork(). Later, to
> prevent ksm_might_unmap_zero_page() from underflowing the counters on
> child exit[1], commit 4d6fc29f3634 ("mm/ksm: fix incorrect KSM counter
> handling in mm_struct during fork") kept the child's inherited per-mm
> counter and added it to the global counter.
>
> Instead of inflating the counters, fix the root cause by resetting the
> child's mm->ksm_zero_pages to 0 in ksm_fork() and clearing the KSM
> zero-page marker via might_clear_ksm_zero_pte() when copying present
> PTEs in __copy_present_ptes(). With the marker cleared,
> ksm_might_unmap_zero_page() will not decrement the counters on child
> exit, MADV_UNMERGEABLE in the child will not unnecessarily unshare
> inherited zero pages, and the global counter remains untouched.
>
> [1] https://lore.kernel.org/all/53a7bf3d-843d-4e19-b0a3-cc6852fe72c1@xxxxxxxxxx/
>
> Fixes: 4d6fc29f3634 ("mm/ksm: fix incorrect KSM counter handling in mm_struct during fork")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Xu Xin (vivo) <xu.xin@xxxxxxxxx>
> ---
> Documentation/admin-guide/mm/ksm.rst | 7 ++++++-
> include/linux/ksm.h | 18 +++++++++++++++---
> mm/memory.c | 2 ++
> 3 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> index c329ca747b8c..8968ae3f55c0 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -214,7 +214,12 @@ stable_node_dups
> number of duplicated KSM pages
> ksm_zero_pages
> how many zero pages that are still mapped into processes were mapped by
> - KSM when deduplicating.
> + KSM when deduplicating. Note: on fork(), the child process does not
> + inherit the ``ksm_zero_pages`` counter, and any inherited KSM-placed
> + zero-page mappings are converted into ordinary shared zero-page
> + mappings. Consequently, these mappings are neither accounted for in
> + the child's counter nor unshared when ``MADV_UNMERGEABLE`` is called
> + in the child.
>
> When ``use_zero_pages`` is/was enabled, the sum of ``pages_sharing`` +
> ``ksm_zero_pages`` represents the actual number of pages saved by KSM.
> diff --git a/include/linux/ksm.h b/include/linux/ksm.h
> index 596c04ca7326..62fa8ca803ed 100644
> --- a/include/linux/ksm.h
> +++ b/include/linux/ksm.h
> @@ -32,6 +32,15 @@ void __ksm_exit(struct mm_struct *mm);
> */
> #define is_ksm_zero_pte(pte) (is_zero_pfn(pte_pfn(pte)) && pte_dirty(pte))
>
> +/* Clear KSM's marker on zero-page PTEs (e.g., on fork). */
This function would be better called "ksm_fork_pte"
Drop this comment and instead ...
> +static inline pte_t might_clear_ksm_zero_pte(pte_t pte)
> +{
Explain here *why* we are doing this.
> + if (is_ksm_zero_pte(pte))
> + return pte_mkclean(pte);> +
But I'd move the check into the caller and only clear here.
IOW, the following on the caller site:
diff --git a/mm/memory.c b/mm/memory.c
index ad5511b2e949a..ee4545a181598 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1184,8 +1184,11 @@ copy_present_ptes(struct vm_area_struct *dst_vma, struct
vm_area_struct *src_vma
int err, nr;
page = vm_normal_page(src_vma, addr, pte);
- if (unlikely(!page))
+ if (unlikely(!page)) {
+ if (unlikely(is_ksm_zero_pte(pte)))
+ pte = ksm_fork_pte(pte);
goto copy_pte;
+ }
folio = page_folio(page);
--
Cheers,
David