[PATCH] drm/panthor: Fix overflow in fdinfo engine time conversion
From: Haoming Gao
Date: Sat Nov 21 2026 - 10:27:46 EST
The timestamp counter accumulates GPU ticks per DRM client. Multiplying
that counter by NSEC_PER_SEC in u64 can overflow before the division by
the timer frequency, even when the result in nanoseconds fits in u64.
On an RK3588 with a 24 MHz timer, drm-engine-panthor dropped from
768569012750 ns to 422647638 ns between two reads of the same client's
fdinfo. The GPU cycle counter continued to advance.
Use mul_u64_u64_div_u64_roundup() to preserve the full product and keep
the existing rounding. The helper was checked against a 128-bit
reference on the board, including at the first wrap boundary.
Fixes: e16635d88fa0 ("drm/panthor: add DRM fdinfo support")
Signed-off-by: Haoming Gao <Naixumogu@xxxxxxxxxxx>
---
drivers/gpu/drm/panthor/panthor_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index dc8d0191aef4..39b827a9b9cc 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -8,6 +8,7 @@
#endif
#include <linux/list.h>
+#include <linux/math64.h>
#include <linux/module.h>
#include <linux/of_platform.h>
#include <linux/pagemap.h>
@@ -1708,8 +1709,8 @@ static void panthor_gpu_show_fdinfo(struct panthor_device *ptdev,
if (ptdev->profile_mask & PANTHOR_DEVICE_PROFILING_TIMESTAMP) {
#ifdef CONFIG_ARM_ARCH_TIMER
drm_printf(p, "drm-engine-panthor:\t%llu ns\n",
- DIV_ROUND_UP_ULL((pfile->stats.time * NSEC_PER_SEC),
- arch_timer_get_cntfrq()));
+ mul_u64_u64_div_u64_roundup(pfile->stats.time, NSEC_PER_SEC,
+ arch_timer_get_cntfrq()));
#endif
}
if (ptdev->profile_mask & PANTHOR_DEVICE_PROFILING_CYCLES)
base-commit: 878c885830ef004a32e8974c4d1ae14e2ea30c5a
--
2.43.0