Re: [RFC PATCH v3 09/10] iommu/riscv: Add riscv_iommu_attach_dev_nested
From: Andrew Jones
Date: Sat Nov 21 2026 - 10:49:44 EST
On Thu, Nov 19, 2026 at 09:27:43PM +0800, Gong Shuai wrote:
...
> + if (riscv_iommu_bond_link(s2_parent, dev, nested_domain->viommu->gscid))
> + return -ENOMEM;
> +
> + riscv_iommu_iodir_update(iommu, dev, &dc);
> + riscv_iommu_bond_unlink(info->domain, dev);
> + info->domain = s2_parent;
> +
When moving between the S2 parent and a nested domain on it, the parent
briefly has two bonds for dev. bond_link() puts the new bond after the
first bond with the same GSCID, which may come before dev's old bond,
and since it's then dev's first bond, bond_unlink() removes it. dev is
left bonded with its old GSCID, so its new GSCID misses invalidations
once no other device's bond has it.
Passing the old domain to bond_unlink(), like I do in [1] for a
different reason, would let it remove the bond matching both dev and
old's GSCID.
[1] https://lore.kernel.org/all/20260928143113.49838-12-andrew.jones@xxxxxxxxxxxxxxxx/
Thanks,
drew