Re: [PATCH 3/4] dt-bindings: phy: cadence-torrent: add phy-mode constants

From: Krzysztof Kozlowski

Date: Sat Nov 21 2026 - 11:20:33 EST


On Fri, Nov 20, 2026 at 01:55:51PM +0100, Benjamin Robin wrote:
> Add the `CDNS_TORRENT_MODE_*` constants to
> include/dt-bindings/phy/phy-cadence.h such as SATA-LP and 2500BASE-X.

But why? Why do we need more of these properties?

>
> These constants are used by the new Cadence Torrent PHY driver and
> are referenced by the `cdns,phy-mode` property of the Cadence Torrent
> PHY binding to select the PHY mode.

That's obvious, explain why you are duplicating phy type instead.

Best regards,
Krzysztof