Re: [PATCH net-next v11 2/4] net: mana: give each HWC message slot its own completion state

From: netdev-bot+sashiko

Date: Sat Nov 21 2026 - 11:29:44 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message for "net: mana: give each HWC message slot its
own completion state" ends with two trailers the kernel does not…

--

net: mana: give each HWC message slot its own completion state

This commit adds a per-slot spinlock to struct hwc_caller_ctx in the MANA
hardware channel. The lock lets the response handler and the waiting sender
agree on the output buffer, error and device status of each message slot.

Slot state is reinitialized under both the bitmap and per-slot locks. The
output buffer is withdrawn before every return from
mana_hwc_send_request(). Status handling and cleanup are split out into
mana_hwc_response_status() and mana_hwc_finish_request().

Link: https://lore.kernel.org/r/20260908035201.402424-3-longli@xxxxxxxxxxxxx
Link: https://lore.kernel.org/r/20260908035201.402424-4-longli@xxxxxxxxxxxxx
Link: https://lore.kernel.org/r/179196575434.434549.4428132041097324407@xxxxxxxxxx
Link: https://lore.kernel.org/r/179196575640.434549.9102950927041409151@xxxxxxxxxx
Link: https://lore.kernel.org/r/179455239815.2199510.4673285259543925635@xxxxxxxxxx

> Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
> Signed-off-by: Wei Hu <weh@xxxxxxxxxxxxx>
> Co-authored-by: Copilot <223556219+Copilot@xxxxxxxxxxxxxxxxxxxxxxxx>
> Copilot-Session: 8c2361e6-c0f4-4b0c-bf01-b5e4cdacec50

[Severity: Low]
This isn't a bug, but should these last two trailers go into the kernel
history?

The kernel does not recognise Co-authored-by: as a tag, and checkpatch.pl
warns about it with "Non-standard signature: Co-authored-by:".

The closest kernel tag is Co-developed-by:. It must be followed by a
Signed-off-by from the co-developer. AI agents must not add Signed-off-by
(see Documentation/process/coding-assistants.rst), so an AI agent cannot
meet that requirement.

Copilot-Session: is a session ID internal to the tool. It means nothing to
maintainers or to stable tooling.

The other patches in the series carry the same trailers. Could they be
dropped from all of them? Any AI assistance could be described in the
commit body instead.

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794751992.git.weh%40linux.microsoft.com