[PATCH v2] phy: rockchip: inno-dsidphy: fix 1.5 GHz rate units
From: ZhuXiangyu
Date: Sat Nov 21 2026 - 12:11:27 EST
The 1.5 GHz Innosilicon DSI PHY timing table stores its rates in Mbps,
whereas the other timing tables and the lookup loop use Hz. When
enabling a mode, the driver compares inno->pll.rate in Hz (e.g.
372000000) against timings[].rate in Mbps (e.g. 400), so no entry
matches. The loop falls through to the last, fastest entry and programs
an excessively large TLPX/LPX counter, preventing panels from decoding
low-power DCS initialization commands.
Convert the 1.5 GHz timing table rate values to Hz so the lookup
selects the matching entry.
Tested on an RK3506B board: the panel receives the low-power init
sequence and the framebuffer console displays properly.
Fixes: 785a9d5bb145 ("phy: rockchip: inno-dsidphy: Add support for rk3506")
Signed-off-by: Xiangyu Zhu <1194781887@xxxxxx>
---
Changes in v2:
- Split out from the combined drm/phy patch into a standalone phy
subsystem patch per Heiko's review.
- Limit recipients to phy and Rockchip maintainers/lists.
- Fix Signed-off-by author name formatting.
.../phy/rockchip/phy-rockchip-inno-dsidphy.c | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
index 6ad04b0c..fcf7aa17 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
@@ -282,20 +282,20 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_1ghz[] = {
static const
struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_1_5ghz[] = {
- { 110, 0x02, 0x7f, 0x16, 0x02, 0x02},
- { 150, 0x02, 0x7f, 0x16, 0x03, 0x02},
- { 200, 0x02, 0x7f, 0x17, 0x04, 0x02},
- { 250, 0x02, 0x7f, 0x17, 0x05, 0x04},
- { 300, 0x02, 0x7f, 0x18, 0x06, 0x04},
- { 400, 0x03, 0x7e, 0x19, 0x07, 0x04},
- { 500, 0x03, 0x7c, 0x1b, 0x07, 0x08},
- { 600, 0x03, 0x70, 0x1d, 0x08, 0x10},
- { 700, 0x05, 0x40, 0x1e, 0x08, 0x30},
- { 800, 0x05, 0x02, 0x1f, 0x09, 0x30},
- {1000, 0x05, 0x08, 0x20, 0x09, 0x30},
- {1200, 0x06, 0x03, 0x32, 0x14, 0x0f},
- {1400, 0x09, 0x03, 0x32, 0x14, 0x0f},
- {1500, 0x0d, 0x42, 0x36, 0x0e, 0x0f},
+ { 110000000, 0x02, 0x7f, 0x16, 0x02, 0x02},
+ { 150000000, 0x02, 0x7f, 0x16, 0x03, 0x02},
+ { 200000000, 0x02, 0x7f, 0x17, 0x04, 0x02},
+ { 250000000, 0x02, 0x7f, 0x17, 0x05, 0x04},
+ { 300000000, 0x02, 0x7f, 0x18, 0x06, 0x04},
+ { 400000000, 0x03, 0x7e, 0x19, 0x07, 0x04},
+ { 500000000, 0x03, 0x7c, 0x1b, 0x07, 0x08},
+ { 600000000, 0x03, 0x70, 0x1d, 0x08, 0x10},
+ { 700000000, 0x05, 0x40, 0x1e, 0x08, 0x30},
+ { 800000000, 0x05, 0x02, 0x1f, 0x09, 0x30},
+ {1000000000, 0x05, 0x08, 0x20, 0x09, 0x30},
+ {1200000000, 0x06, 0x03, 0x32, 0x14, 0x0f},
+ {1400000000, 0x09, 0x03, 0x32, 0x14, 0x0f},
+ {1500000000, 0x0d, 0x42, 0x36, 0x0e, 0x0f},
};
static const
--
2.47.3