[PATCH ath-next v2 1/2] wifi: ath10k: release the PCI interrupt mode when probe fails

From: Julius Bairaktaris

Date: Sat Nov 21 2026 - 12:54:09 EST


Since commit 1cfd3426ef98 ("ath10k: Fix NULL pointer dereference in AHB
device probe") the err_deinit_irq label of ath10k_pci_probe() only calls
ath10k_pci_release_resource(), so a probe that fails after
ath10k_pci_init_irq() leaves MSI enabled on the device, or the legacy
interrupt enabled in the target. With MSI, the device's MSI data is
released at the end of the failed probe while its vectors are still
allocated, which warns in msi_device_data_release(), and the next probe
of the device hits the WARN_ON_ONCE(dev->msi_enabled) in
__pci_enable_msi_range() and falls back to legacy interrupts.

Call ath10k_pci_deinit_irq() again before releasing the resources, as
ath10k_pci_remove() does.

Fixes: 1cfd3426ef98 ("ath10k: Fix NULL pointer dereference in AHB device probe")
Signed-off-by: Julius Bairaktaris <julius@xxxxxxxxxxxxxx>
---
Changes in v2:
- New: the probe error path left MSI enabled (found while testing 2/2).

drivers/net/wireless/ath/ath10k/pci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 335bc7c488e4..4843a41ea801 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3716,6 +3716,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
ath10k_pci_free_irq(ar);

err_deinit_irq:
+ ath10k_pci_deinit_irq(ar);
ath10k_pci_release_resource(ar);

err_sleep:
--
2.53.0