Re: [PATCH v4] media: i2c: ov13858: add regulator, clock and reset GPIO handling

From: Haipeng Lin

Date: Sat Nov 21 2026 - 14:02:33 EST


On 10/16/26 5:02 PM, Sergey Lebedev wrote:
> The driver assumes the sensor is already powered when probe() reads its
> chip ID. That holds where the rails and clock are ACPI power resources,
> but not where an INT3472 companion device registers them as regulators, a
> clock and a reset GPIO for the sensor driver to consume, which this
> driver does not do.
>
> Request the three supplies and the reset GPIO, and sequence them along
> with the clock the driver already looks up, in runtime PM callbacks.

[...]

Hi Sergey,

Tested on a Surface Pro 11 (X1P-64-100, LCD, 5G) on a v7.3.4-based tree
with out-of-tree CCI/CAMSS and SP11 camera DT nodes and George's DT v2
patch on top:

- avdd, dovdd, dvdd, clock (19.2 MHz) and reset GPIO all come from DT;
the sensor probes and streams 4224x3136 at ~30 fps through CAMSS and
libcamera 0.7.2;
- All three supply rails are off when idle, on when streaming.
- v4l2-compliance on the subdev passes 46/46.

I did not test system suspend while streaming.

Tested-by: Haipeng Lin <jimmie.lin@xxxxxxxxx> # Surface Pro 11 (LCD 5G)

Thanks,
Haipeng