[PATCH 2/3] wifi: ath10k: add firmware feature bit to skip quiet mode
From: Gianluca Boiano
Date: Sat Nov 21 2026 - 14:50:07 EST
WCN3990 firmware advertises WMI_SERVICE_THERM_THROT, so the existing
service-bit guard in ath10k_thermal_set_throttling() lets the pdev quiet
mode command through. The firmware crashes on it deterministically and
takes the modem down with it.
Rather than hardcoding a chip check, add ATH10K_FW_FEATURE_NO_QUIET_MODE
so affected firmware images can opt out via firmware-N.bin. With the bit
set, thermal throttling through the ath10k cooling device has no effect.
Tested on SDM660 (WCN3990).
Signed-off-by: Gianluca Boiano <morf3089@xxxxxxxxx>
---
drivers/net/wireless/ath/ath10k/core.c | 1 +
drivers/net/wireless/ath/ath10k/core.h | 5 +++++
drivers/net/wireless/ath/ath10k/thermal.c | 5 +++++
3 files changed, 11 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index d37add4cf..6272e0f62 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -816,6 +816,7 @@ static const char *const ath10k_core_fw_feature_str[] = {
[ATH10K_FW_FEATURE_PEER_FIXED_RATE] = "peer-fixed-rate",
[ATH10K_FW_FEATURE_IRAM_RECOVERY] = "iram-recovery",
[ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT] = "no-chan-stat-event",
+ [ATH10K_FW_FEATURE_NO_QUIET_MODE] = "no-quiet-mode",
};
static unsigned int ath10k_core_get_fw_feature_str(char *buf,
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 29a4c0d74..5dd21f063 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -841,6 +841,11 @@ enum ath10k_fw_features {
/* Firmware crashes when asked for channel stats events during scan. */
ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT = 23,
+ /* Firmware advertises WMI_SERVICE_THERM_THROT but crashes when it
+ * receives the pdev quiet mode command.
+ */
+ ATH10K_FW_FEATURE_NO_QUIET_MODE = 24,
+
/* keep last */
ATH10K_FW_FEATURE_COUNT,
};
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c
index 9bb486f8e..c558a9e7c 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.c
+++ b/drivers/net/wireless/ath/ath10k/thermal.c
@@ -139,6 +139,11 @@ void ath10k_thermal_set_throttling(struct ath10k *ar)
if (ar->state != ATH10K_STATE_ON)
return;
+ /* running_fw is only valid once the device is up */
+ if (test_bit(ATH10K_FW_FEATURE_NO_QUIET_MODE,
+ ar->running_fw->fw_file.fw_features))
+ return;
+
period = ar->thermal.quiet_period;
duration = (period * ar->thermal.throttle_state) / 100;
enabled = duration ? 1 : 0;
--
2.56.1