[PATCH 1/7] drm/msm/dp: configure voltage swing and pre-emphasis for all active lanes

From: Gianfranco Mariotti

Date: Sat Nov 21 2026 - 16:41:25 EST


msm_dp_ctrl_set_vx_px() only populated voltage[0] and pre[0] and left
phy_opts->dp.lanes and phy_opts->dp.link_rate unset when calling
phy_configure(), leaving lanes 1..3 unconfigured on multi-lane links.

Populate phy_opts->dp.lanes and phy_opts->dp.link_rate from the active
link parameters and program voltage swing and pre-emphasis across all
active lanes.

Fixes: b4745f741e79 ("drm/msm/dp: move phy_configure_opts to dp_ctrl")
Signed-off-by: Gianfranco Mariotti <gianfranco.mariotti94@xxxxxxxxx>
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index abd3dcdad03c..b896196cf244 100644
--- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
+++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
@@ -1374,13 +1374,18 @@ static int msm_dp_ctrl_wait4video_ready(struct msm_dp_ctrl_private *ctrl)
}

static int msm_dp_ctrl_set_vx_px(struct msm_dp_ctrl_private *ctrl,
- u8 v_level, u8 p_level)
+ u8 v_level, u8 p_level)
{
union phy_configure_opts *phy_opts = &ctrl->phy_opts;
+ int i;
+
+ phy_opts->dp.lanes = ctrl->link->link_params.num_lanes;
+ phy_opts->dp.link_rate = ctrl->link->link_params.rate / 100;

- /* TODO: Update for all lanes instead of just first one */
- phy_opts->dp.voltage[0] = v_level;
- phy_opts->dp.pre[0] = p_level;
+ for (i = 0; i < phy_opts->dp.lanes; i++) {
+ phy_opts->dp.voltage[i] = v_level;
+ phy_opts->dp.pre[i] = p_level;
+ }
phy_opts->dp.set_voltages = 1;
phy_configure(ctrl->phy, phy_opts);
phy_opts->dp.set_voltages = 0;
--
2.25.1