Re: [PATCH 10/10] iio: light: tsl2591: Prevent infinite recursion on threshold boundaries
From: Jonathan Cameron
Date: Sat Nov 21 2026 - 18:14:08 EST
On Thu, 19 Nov 2026 15:30:43 +0000
Lee Jones <lee@xxxxxxxxxx> wrote:
> tsl2591_set_als_lower_threshold() adjusts the upper threshold to
> als_lower_threshold + 1 whenever the new lower threshold is greater than
> or equal to the current upper threshold, and
> tsl2591_set_als_upper_threshold() symmetrically adjusts the lower
> threshold to als_upper_threshold - 1.
>
> Writing 65535 (TSL2591_ALS_MAX_VALUE) to the falling threshold wraps the
> 16-bit addition to 0 and calls tsl2591_set_als_upper_threshold(chip, 0),
> which then wraps 0 - 1 back to 65535 and calls
> tsl2591_set_als_lower_threshold(chip, 65535) in an infinite mutual
> recursion until the kernel stack overflows. Writing 0 to the rising
> threshold triggers the same cycle whenever the lower threshold is
> non-zero.
>
> Reject als_lower_threshold == TSL2591_ALS_MAX_VALUE and
> als_upper_threshold == 0 with -EINVAL, propagate errors from the
> cross-calls, and only update chip->als_settings once the I2C writes
> succeed.
>
> Fixes: 2335f0d7c790 ("iio: light: Added AMS tsl2591 driver implementation")
> Closes: https://sashiko.dev/#/bug/linux-29f0f993-c799-4717-9daa-d0ad367f4e6d
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
Ouch.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan