[PATCH v16 22/31] firmware: arm_scmi: Add Telemetry debugfs SHMTI dump support

From: Cristian Marussi

Date: Sat Nov 21 2026 - 18:44:44 EST


Expose one debugfs entry for each discovered SHMTI that can be used to
dump the related SHMTI in binary form from TBGN up to TEND markers.

No processing is done kernel side, beside using proper accessors for
device memory.

Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
---
v15 --> v16
- initialize/destroy debugFS around SHMTIs init
v14 --> v15
- cleanup local debugfs subtree with debugfs_remove_recursive on remove
v12 --> v13
- get inode lock on time update
v11 --> v12
- fix debugfs shmti dump file to use the SID as name
v8 --> v9
- use kvzalloc/kfree
- use file_update_time to update debugfs file ts
v5 --> v6
- added mutex to protect binary dump buffer during reads (Sashiko)
- using debugfs_create_file_size() (Sashiko)
---
drivers/firmware/arm_scmi/telemetry.c | 103 ++++++++++++++++++++++++++
1 file changed, 103 insertions(+)

diff --git a/drivers/firmware/arm_scmi/telemetry.c b/drivers/firmware/arm_scmi/telemetry.c
index b74371bc41d5..cd0bd0015c82 100644
--- a/drivers/firmware/arm_scmi/telemetry.c
+++ b/drivers/firmware/arm_scmi/telemetry.c
@@ -9,9 +9,11 @@
#include <linux/bitfield.h>
#include <linux/compiler_types.h>
#include <linux/completion.h>
+#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/err.h>
+#include <linux/fs.h>
#include <linux/hash.h>
#include <linux/hashtable.h>
#include <linux/jhash.h>
@@ -450,6 +452,14 @@ struct telemetry_shmti {
#define TDCF_OFFS(_b, _p) \
((unsigned long)((__force void *)(_p) - (__force void *)(_b)))

+struct scmi_telemetry_dbg_shmti {
+ struct telemetry_shmti *shmti;
+ size_t buf_sz;
+ void *buf;
+ /* Protect this descriptor from concurrent readers using it */
+ struct mutex mtx;
+};
+
#define SHMTI_EPLG(s) \
({ \
struct telemetry_shmti *_s = (s); \
@@ -562,6 +572,7 @@ struct telemetry_info {
unsigned int default_blk_ts_rate;
const struct scmi_protocol_handle *ph;
struct telemetry_shmti *shmti;
+ struct dentry *shmti_top;
struct telemetry_de *tdes;
struct xarray xa_des;
struct telemetry_uuid *primary_uuid;
@@ -1356,6 +1367,10 @@ static void scmi_telemetry_tdes_cleanup(void *arg)
scmi_telemetry_de_unlink(&tde->de);
scmi_telemetry_free_tde_put(ti, tde);
}
+
+ /* Safe removal of SHMTI debugfs tree before freeing underlying data */
+ if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_PROTOCOLS))
+ debugfs_remove_recursive(ti->shmti_top);
}

static int scmi_telemetry_de_descriptors_get(struct telemetry_info *ti)
@@ -1533,6 +1548,91 @@ scmi_telemetry_enumerate_common_intervals(struct telemetry_info *ti)
ti->info.intervals);
}

+static int scmi_telemetry_dbg_shmti_open(struct inode *inode, struct file *filp)
+{
+ struct scmi_telemetry_dbg_shmti *sblob;
+ struct telemetry_shmti *shmti;
+
+ if (!inode->i_private)
+ return -ENODEV;
+
+ shmti = inode->i_private;
+ sblob = kzalloc_obj(*sblob);
+ if (!sblob)
+ return -ENOMEM;
+
+ sblob->shmti = shmti;
+ sblob->buf = kvzalloc(shmti->info.len, GFP_KERNEL);
+ if (!sblob->buf) {
+ kfree(sblob);
+ return -ENOMEM;
+ }
+
+ mutex_init(&sblob->mtx);
+
+ filp->private_data = sblob;
+
+ return 0;
+}
+
+static ssize_t scmi_telemetry_dbg_shmti_read(struct file *filp, char __user *buf,
+ size_t count, loff_t *ppos)
+{
+ struct scmi_telemetry_dbg_shmti *sblob = filp->private_data;
+
+ /* Dump on first read and again after each rewind to start pos */
+ guard(mutex)(&sblob->mtx);
+ if (!sblob->buf_sz || *ppos == 0) {
+ struct inode *ino = file_inode(filp);
+
+ memcpy_fromio(sblob->buf, sblob->shmti->base,
+ sblob->shmti->info.len);
+ sblob->buf_sz = sblob->shmti->info.len;
+ /* update inode timestamps */
+ inode_lock(ino);
+ file_update_time(filp);
+ inode_unlock(ino);
+ }
+
+ return simple_read_from_buffer(buf, count, ppos, sblob->buf, sblob->buf_sz);
+}
+
+static int scmi_telemetry_dbg_shmti_release(struct inode *inode, struct file *filp)
+{
+ struct scmi_telemetry_dbg_shmti *sblob = filp->private_data;
+
+ kvfree(sblob->buf);
+ kfree(sblob);
+
+ return 0;
+}
+
+static const struct file_operations scmi_telemetry_dbg_shmti_fops = {
+ .open = scmi_telemetry_dbg_shmti_open,
+ .release = scmi_telemetry_dbg_shmti_release,
+ .read = scmi_telemetry_dbg_shmti_read,
+ .llseek = generic_file_llseek,
+ .owner = THIS_MODULE,
+};
+
+static void scmi_telemetry_debugfs_initialize(struct telemetry_info *ti)
+{
+ const struct scmi_protocol_handle *ph = ti->ph;
+ struct dentry *top;
+
+ top = ph->hops->debugfs_proto_dentry_get(ph);
+ ti->shmti_top = debugfs_create_dir("shmtis", top);
+
+ for (unsigned int i = 0; i < ti->num_shmti; i++) {
+ char id[16];
+
+ snprintf(id, 16, "%u", ti->shmti[i].info.sid);
+ debugfs_create_file_size(id, 0444, ti->shmti_top, &ti->shmti[i],
+ &scmi_telemetry_dbg_shmti_fops,
+ ti->shmti[i].info.len);
+ }
+}
+
static int iter_shmti_update_state(struct scmi_iterator_state *st,
const void *response, void *priv)
{
@@ -1748,6 +1848,9 @@ static int scmi_telemetry_enumerate_shmti(struct telemetry_info *ti)
/* Expose the fully initialized SHMTI infos */
smp_store_release(&ti->info.base.num_shmtis, ti->num_shmti);

+ if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_PROTOCOLS))
+ scmi_telemetry_debugfs_initialize(ti);
+
return devm_add_action_or_reset(ph->dev, scmi_telemetry_tdes_cleanup, ti);
}

--
2.54.0