RE: [PATCH rtw-next 1/3] wifi: rtl8xxxu: honour the rate of injected frames on gen1 chips

From: Ping-Ke Shih

Date: Sat Nov 21 2026 - 20:51:57 EST


Ahmet Zeren via B4 Relay <devnull+niko3x.proton.me@xxxxxxxxxx> wrote:
> From: Ahmet Zeren <niko3x@xxxxxxxxx>
>
> When a frame is injected with a rate in its radiotap header, the driver
> ignores it and leaves the choice to the firmware rate adaptation. On a
> RTL8192CU every injected frame went out at MCS 7, whatever was asked.
>
> Use the injected rate and guard interval, and disable rate fallback so
> the frame is sent at exactly that rate.
>
> Tested on RTL8192CU (0bda:8178) in monitor mode on 2.4 GHz: 1, 5.5, 6
> and 54 Mbps, MCS 0/7/8/15 with long and short GI were all received at
> the requested rate. Frames without a radiotap rate are unchanged.
>
> Signed-off-by: Ahmet Zeren <niko3x@xxxxxxxxx>

The comment is not unnecessary. Otherwise, looks good to me:

Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
> drivers/net/wireless/realtek/rtl8xxxu/core.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index 604bb1e5b0..969875fd54 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -5223,6 +5223,28 @@ static void rtl8xxxu_dump_action(struct device *dev,
> }
> }
>
> +/*
> + * Use the rate from the radiotap header of an injected frame, if any.
> + * mac80211 has already checked it against what we advertise.
> + */

No need the comment. The code does as the comment.

> +static bool rtl8xxxu_tx_rate_inject(struct ieee80211_tx_info *tx_info,
> + u32 *rate, bool *sgi)
> +{
> + struct ieee80211_tx_rate *txrate = &tx_info->control.rates[0];
> +
> + if (!(tx_info->control.flags & IEEE80211_TX_CTRL_RATE_INJECT))
> + return false;
> +
> + if (txrate->flags & IEEE80211_TX_RC_MCS)
> + *rate = DESC_RATE_MCS0 + txrate->idx;
> + else
> + *rate = rtl8xxxu_legacy_ratetable[txrate->idx].hw_value;
> +
> + *sgi = txrate->flags & IEEE80211_TX_RC_SHORT_GI;
> +
> + return true;
> +}
> +