Re: [PATCH net-next v5 1/4] ipv4: draw rt_genid from a sequence shared by all netns
From: Ralf Lici
Date: Sun Nov 22 2026 - 04:03:04 EST
On Sat, 21 Nov 2026 18:21:19 -0500, Qiliang Yuan <qiliang.yuan@xxxxxxxxx> wrote:
> An IPv4 route records the rt_genid of the netns it was created in, and
> rt_is_expired() compares it with the rt_genid of the netns its device
> belongs to when the route is checked. Every netns starts its rt_genid
> at 0 and increments it on each cache flush, so different netns often
> hold the same value.
>
> When a device moves to another netns, routes cached through it remain
> usable until dst_dev_put() points them to blackhole_netdev. For a route
> using a nexthop object this happens in nexthop_free_rcu(), which
> free_fib_info_rcu() queues from inside an RCU callback, so the
> rcu_barrier() in __dev_change_net_namespace() does not wait for it. If
> the rt_genid of the new netns matches the cached one in that window,
> ipv4_dst_check() accepts the route and a socket in the old netns keeps
> sending through a device that now belongs to another netns.
>
> Take every rt_genid bump from one sequence shared by all netns, which
> never hands out 0, the value every netns starts with. Inserting a route
> bumps rt_genid, so the routes a netns caches carry values drawn from the
> sequence, which no other netns holds until it wraps after 2^32 bumps. A
> moved device sends again only once it is up in its new netns, and
> NETDEV_UP flushes the route cache there, so that netns no longer holds 0
> either. Publish each value with a cmpxchg on the rt_genid of the netns,
> drawing again if another bump changed it first, so that a bump stalled
> between drawing and publishing cannot overwrite a newer value and
> rt_genid stays monotonic per netns.
>
> A connected UDP socket in netns A caches a route through a nexthop
> object on a veth. The veth is moved to netns B and brought up with one
> RTM_NEWLINK, then the socket sends 200000 datagrams. B's rt_genid is
> bumped 0 to 20 times before the move, 63 trials:
>
> before after change
> trials sending after move (count) 2 0 -100%
> datagrams sent after move (count) 1045 0 -100%
>
> Signed-off-by: Qiliang Yuan <qiliang.yuan@xxxxxxxxx>
Reviewed-by: Ralf Lici <ralf@xxxxxxxxxxxxx>
--
Ralf Lici
Mandelbit Srl