Re: [PATCH] usb: typec: tcpm: fix missed frs_sourcing_vbus() call during FRS
From: Greg Kroah-Hartman
Date: Sun Nov 22 2026 - 05:38:43 EST
On Sun, Nov 22, 2026 at 10:28:38AM +0000, Max Andreev wrote:
> Since commit 0908c5aca31e ("usb: typec: tcpm: AMS and Collision
> Avoidance") the TCPC reports sourcing vbus while the port is still in
> AMS_START with FR_SWAP_SEND as the upcoming state. Because of
> _tcpm_pd_vbus_on() ignores this state, frs_sourcing_vbus() is never called
> during FRS.
>
> On Pixel 11 Pro XL after an FRS from sink to source the phone keeps
> showing the charging indicator, and about 20 seconds later VBUS drops
> and the attached device reboots.
>
> Call frs_sourcing_vbus() from AMS_START when the upcoming state is
> FR_SWAP_SEND.
>
> ---
> I'm not test theese changes on mainline, but tested on Pixel 11 Pro XL
> vendor kernel 6.1 with the same _tcpm_pd_vbus_on() code, as i see
> mainline tcpm.c is identical in this area.
>
> Fixes: 0908c5aca31e ("usb: typec: tcpm: AMS and Collision Avoidance")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Max Andreev <drunkbatya.js@xxxxxxxxx>
Why is this all below the --- line? That will get cut off :(