Re: [PATCH v5 0/5] media: rockchip: rkvdec: add support for the VDPU346 variant
From: Daniel Golle
Date: Sun Nov 22 2026 - 05:57:58 EST
On Sun, Nov 22, 2026 at 11:44:32AM +0400, Christian Hewitt wrote:
> > On 20 Nov 2026, at 9:36 pm, Daniel Golle <daniel@xxxxxxxxxxxxxx> wrote:
> >
> > This series adds the VDPU346 decoder of the RK3566 and RK3568 to the
> > rkvdec driver, for H.264 and HEVC. It continues Christian Hewitt's v3
> > [1]; in the v2 cover letter he offered to pass the series on. The
> > previous posting [2] carried no version in its subject and counts as
> > v4.
>
> The original offer was directed at Detlev based on conversations with
> other Collabora folks who were hinting that he would be able to (and
> it would even be desirable to) fold VDPU346 patches into his work on
> VDPU381/383 which was in-flight at the time.
VDPU381/383 has landed shortly after your initial post, 10 months ago.
Your wording, on a public mailing list, reads
> [...] would be happy to pass the series over to a more experienced
> developer.
I may not have been active in media/drm that much, but am generally very
familiar with kernel development and consider myself reasonably skilled
with C (also "pre-Claude").
As all missing was running the validation suite (and the minimal changes
such as the clock change I've appended to the series) I thought
re-submitting it with the results of the validation suite run would be
the right thing to do.
> However he didn’t take
> the bait and it didn’t happen. The comment is also pre-Claude when my
> coding abilities were more rudimentary. The main reason for the long
> delay in following up has been the length of time it took for Detlev’s
> and related DRM series that permit wider testing to land; a vacation
> over the summer, and then Claude distracting me with a deep dive into
> the Amlogic and Rockchip media stacks that’s resulted in 300+ patches
> that need a proper plan for upstreaming else I’m going to annoy the
> already-overworked media/drm maintainers.
That particular bit, making VDPU436 work, doesn't depend on any of that
future work you may still want to submit. It's immediately useful and
can be tested independently.
> I don’t object to someone upstreaming my patches. I do object to the
> lack of outreach to check on my plans and patch status before blindly
> (and wrongly) assuming there were none.
I didn't mean to overstep you here -- but 10 months of silence and an
offer to hand over the series didn't seem to require any coordination.
> You will find later versions
> of my patches with fixes for changes in surrounding code (as I work
> on something broadly equivalent to drm-tip not Linux 6.18) and from
> further testing in my not-very-abandoned development tree:
>
> https://github.com/chewitt/linux/commits/rockchip-7.4.y
I wasn't aware of yout Github tree which wasn't mentioned anywhere in
your previous submissions. It also seems that this tree has only been
published hours ago, and doesn't contain any changes related to rkvdec
beyond what is also published via the mailing lists.