Re: [PATCH 1/3] dt-bindings: media: qcom,sdm845-camss: Add interconnects

From: Bryan O'Donoghue

Date: Sun Nov 22 2026 - 07:15:45 EST


On 22/11/2026 05:13, EMCP333 via B4 Relay wrote:
From: EMCP333 <emcp@xxxxxxxx>

CAMSS on SDM845 reaches DDR through two camnoc HF ports and one SF
port, and its registers through the config NoC. Describe the four
paths, named as in the sm6150 binding, which has the same two HF ports.

They are optional, so existing device trees stay valid. The driver
votes on them where they are present.

The code and this changelog were prepared with the help of an AI coding
assistant. The submitter has reviewed both and takes responsibility for
them.



Signed-off-by: EMCP333 <emcp@xxxxxxxx>
---
.../devicetree/bindings/media/qcom,sdm845-camss.yaml | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index be09cf3a3b..8c87ecd406 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -76,6 +76,16 @@ properties:
- const: vfe1
- const: vfe_lite

+ interconnects:
+ maxItems: 4
+
+ interconnect-names:
+ items:
+ - const: ahb
+ - const: hf_0
+ - const: hf_1
+ - const: sf_mnoc
+
iommus:
maxItems: 4

@@ -233,6 +243,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,camcc-sdm845.h>
#include <dt-bindings/clock/qcom,gcc-sdm845.h>
+ #include <dt-bindings/interconnect/qcom,sdm845.h>

soc {
#address-cells = <2>;
@@ -337,6 +348,15 @@ examples:
"vfe1",
"vfe_lite";

+ interconnects = <&gladiator_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_CAMERA_CFG 0>,
+ <&mmss_noc MASTER_CAMNOC_HF0 0 &mem_noc SLAVE_EBI1 0>,
+ <&mmss_noc MASTER_CAMNOC_HF1 0 &mem_noc SLAVE_EBI1 0>,
+ <&mmss_noc MASTER_CAMNOC_SF 0 &mem_noc SLAVE_EBI1 0>;

Ah come on. "The LLM made this and I reviewed it" but this is what sm6150 upstream looks like:


interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
&config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
<&mmss_noc MASTER_CAMNOC_HF0 QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
<&mmss_noc MASTER_CAMNOC_HF1 QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
<&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
interconnect-names = "ahb",
"hf_0",
"hf_1",
"sf_mnoc";

Please _actually_ review it, the patchlog even calls out the source yaml used as reference.

+ interconnect-names = "ahb",
+ "hf_0",
+ "hf_1",
+ "sf_mnoc";
+
iommus = <&apps_smmu 0x0808 0x0>,
<&apps_smmu 0x0810 0x8>,
<&apps_smmu 0x0c08 0x0>,

--
2.47.3