[PATCH] media: saa7146: fix a potential memory leak in mxb_attach()
From: Haoxiang Li
Date: Sun Nov 22 2026 - 08:12:48 EST
mxb_probe() allocates a struct mxb and adds an i2c adapter.
If saa7146_register_device() fails, the resources should
be cleaned up to prevent a memory leak.
Fixes: 03b1930efd3c ("V4L/DVB: saa7146: fix regression of the av7110/budget-av driver")
Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
---
drivers/media/pci/saa7146/mxb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/pci/saa7146/mxb.c b/drivers/media/pci/saa7146/mxb.c
index 129d41c1862b..3c399659bb48 100644
--- a/drivers/media/pci/saa7146/mxb.c
+++ b/drivers/media/pci/saa7146/mxb.c
@@ -721,6 +721,8 @@ static int mxb_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_data
if (saa7146_register_device(&mxb->video_dev, dev, "mxb", VFL_TYPE_VIDEO)) {
ERR("cannot register capture v4l2 device. skipping.\n");
saa7146_vv_release(dev);
+ i2c_del_adapter(&mxb->i2c_adapter);
+ kfree(mxb);
return -1;
}
--
2.25.1