Re: [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands

From: Leon Romanovsky

Date: Sun Nov 22 2026 - 08:15:09 EST


On Wed, Nov 18, 2026 at 09:57:52PM +0000, Nikhil P. Rao wrote:
> Commit ec8ee714736e ("ionic: stretch heartbeat detection") notes that
> firmware can take more than 2 seconds to service a device or admin
> queue request, and is only expected to complete it within the ionic
> command timeout of 5 seconds. The RDMA admin queue watchdog gives up
> after 2 seconds, and a timeout resets the RDMA LIF, after which every
> verb fails with -ENODEV. Wait 5 seconds, as ionic does for its own
> admin queue.

Is this a real, user-visible bug, or merely a nice-to-have improvement?

Thanks

>
> Fixes: f3bdbd42702c ("RDMA/ionic: Create device queues to support admin operations")
> Signed-off-by: Nikhil P. Rao <nikhil.rao@xxxxxxx>
> ---
> drivers/infiniband/hw/ionic/ionic_admin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/ionic/ionic_admin.c b/drivers/infiniband/hw/ionic/ionic_admin.c
> index 0ccd869ad8e6..859893568538 100644
> --- a/drivers/infiniband/hw/ionic/ionic_admin.c
> +++ b/drivers/infiniband/hw/ionic/ionic_admin.c
> @@ -19,7 +19,7 @@
> #define IONIC_ADMIN_BUSY_RETRY_MS 1
>
> /* admin queue will be considered failed if a command takes longer */
> -#define IONIC_ADMIN_TIMEOUT (HZ * 2)
> +#define IONIC_ADMIN_TIMEOUT (HZ * 5)
> #define IONIC_ADMIN_WARN (HZ / 8)
>
> /* will poll for admin cq to tolerate and report from missed event */
>
> ---
> base-commit: e7732ec135b501e87ab060d992b3b5f2ec4396c9
> change-id: 20261118-b4-ionic-rdma-admin-timeout-3cc9f4afe247
>
> Best regards,
> --
> Nikhil P. Rao <nikhil.rao@xxxxxxx>
>