[PATCH v2 0/2] ALSA: firewire: Abort transactions on a bus reset
From: Suyuan Wang via B4 Relay
Date: Sun Nov 22 2026 - 08:46:42 EST
fcp_avc_transaction() and snd_efw_transaction_run() resend their
command after a bus reset but never move the transaction back to
STATE_PENDING, so both loops keep resending without a retry limit
until sending fails.
As Takashi suggested, v2 no longer resends: on a bus reset the
transaction is ended and -EAGAIN is returned, following the AV/C
general specification, which says that a target discards any
transaction in progress on a bus reset.
Found with a static analysis tool and checked by hand. Compile tested
only (x86_64, W=1); I don't have FireWire audio hardware.
Changes in v2:
- Abort the transaction and return -EAGAIN on a bus reset instead of
rearming it and resending (Takashi).
- Drop ERROR_DELAY_MS (and <linux/delay.h> in fcp.c), now unused.
v1: https://lore.kernel.org/all/20261120-firewire-busreset-v1-0-8bb9079a2984@xxxxxxxxx/
---
Suyuan Wang (2):
ALSA: firewire-lib: Abort the FCP transaction on a bus reset
ALSA: fireworks: Abort the transaction on a bus reset
sound/firewire/fcp.c | 5 ++---
sound/firewire/fireworks/fireworks_transaction.c | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)