Re: [PATCH net v2 0/2] net: dsa: realtek: rtl8365mb: fix FDB lookups in VLAN-unaware bridges
From: Mieczyslaw Nalewaj
Date: Sun Nov 22 2026 - 09:05:04 EST
On Fri, Nov 06, 2026 at 04:02:23PM +0100, Stijn Cleynhens wrote:
> Tested on OpenWrt's 6.18 kernel, which carries the rtl8365mb backports up
> to v7.4; the code these patches touch is the same as in net. A station
> learned behind the uplink that moves behind the CPU port answers 10/10
> pings, its learned entry replaced by the CPU one, with VLAN filtering
> switched off at runtime: on an RTL8367S (TP-Link Deco X50-Outdoor), and
> on an RTL8367S-VB (Deco X50-PoE, with the family D series applied and a
> family D branch in rtl8365mb_vlan_pvid_port_commit()), where it also
> passes with VLAN filtering on. Before these patches the RTL8367S
> answered 0/10. Both patches build without warnings with W=1 C=1.
>
> Note for Mieczyslaw's RTL8367S-VB series in net-next (v8): patch 2
> replaces rtl8365mb_vlan_pvid_port_set() and
> rtl8365mb_vlan_pvid_port_clear() with rtl8365mb_vlan_pvid_port_commit(),
> which gets the target VID (0 for the neutral PVID) and the filtering
> state. The family D paths that series adds to set and clear become one
> branch there that writes the PVID register and the frame filter from
> those two inputs. Happy to send that as a follow-up once both are in.
Hi Stijn,
thank you for testing on an RTL8367S-VB and for the note about my series.
It is now at v13 (14 patches): [link to v13 on lore]
Since you have family D hardware and work on FDB lookups in VLAN-unaware
bridges, could you please take a look at two patches of it, and test them
if you have time:
- 7/14, which makes IVL_EN of the 4K VLAN entries follow the VLAN
filtering state on family D;
- 12/14, which handles the L2/LUT differences on family D: no EFID, so
an offloaded VLAN-unaware bridge is put in FID 1 with the port-based FID
registers while standalone ports stay in FID 0, plus the lookup-hit
isolation fallback (0x0A10 bit 0).
12/14 changed the most in v13 and has had the least testing. Your case of
a station moving between a user port and the CPU port, with VLAN
filtering on and off, would be a very useful check for it.
Best regards,
Mieczyslaw Nalewaj