Re: [RFC PATCH v9 1/3] ocfs2: Add new ocfs2_map_blocks() to introduce iomap feature
From: Joseph Qi
Date: Sun Nov 22 2026 - 09:29:20 EST
On 11/21/26 2:34 AM, Christoph Hellwig wrote:
> On Fri, Nov 20, 2026 at 02:00:11PM +0800, Heming Zhao wrote:
>> As part of migrating OCFS2 DIO read/write code paths towards the modern
>> and performant iomap framework, here introduces ocfs2_map_blocks() to
>> replace the legacy, high-overhead buffer_head based block mapping
>> routines.
>
> Do you have numbers to antiy the high overhead? Or should this be toned
> down a bit?
>
>> In addition, OCFS2_MAP_* flags are defined to gridge OCFS2 internal block
>> mapping flags with the iomap API requirements.
>
> "gridge"?
>
I think it is a typo for "bridge".
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>