Re: [PATCH net v2] net/sched: act_ife: return -EAGAIN after dropping rtnl_lock in load_metaops_and_vet()
From: Stephen Hemminger
Date: Sun Nov 22 2026 - 12:18:43 EST
On Sun, 22 Nov 2026 20:45:52 +0800
YanXin Li via B4 Relay <devnull+fadouse.pm.me@xxxxxxxxxx> wrote:
> + if (ops && rtnl_held) {
> + /* We dropped the RTNL mutex in order to perform the
> + * module load. Tell the caller to replay the request
> + * under a fresh RTNL critical section.
> + */
I prefer that comments stay in "short and sweet" style.
AI and new developers seem to like long comments.
This comment has the classic /* add one to i */ style...
In other words the comment doesn't tell human more than is already
obvious from the code.