Re: [PATCH v3 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A

From: Jonathan Cameron

Date: Sun Nov 22 2026 - 13:15:39 EST


On Sun, 22 Nov 2026 10:52:45 +0300
Adil Hüsrev Tepe <tadilhusrev@xxxxxxxxx> wrote:

> On Sat, Nov 21, 2026 at 01:23:42PM +0100, Krzysztof Kozlowski wrote:
> > Do not attach (thread) your patchsets to some other threads (unrelated
> > or older versions). This buries them deep in the mailbox and might
> > interfere with applying entire sets.
>
> Understood, sorry. v4 will be sent with b4 as a new thread, not as a
> reply to v1.
>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Thank you. One thing up front: Jonathan's review of the driver makes
> the vdd supply required, so in v4 vdd-supply moves into "required"
> here. Since that changes the binding, I'll leave your tag off this
> patch and say why below the ---, unless you're happy for me to keep it.

Whilst I agree it should be required in the binding make sure you fully
understand what the difference between the optional and normal
requests for regulators are. It is not about whether they are in
the dt-binding or not! Code can work without it being their using
either of those interfaces.

Jonathan

>
> Thanks,
> Adil