Re: [PATCH v5 0/4] iio: light: ltr501: Add LTR-659PS-01 prox sensor support

From: Jonathan Cameron

Date: Sun Nov 22 2026 - 15:04:36 EST


On Sun, 22 Nov 2026 10:07:49 +0200
Svyatoslav Ryhel <clamor95@xxxxxxxxx> wrote:

> Add support for the Lite-On LTR-659PS-01 proximity sensor. This device is
> nearly identical to the LTR-559ALS-01, but omits all elements related to
> ambient light sensing.
>
This seems to address Arnav's review on v4 and looks good to me.

So given I might not get back to the tree for a few days I'll apply it now
and we can let the bots have fun with it. Still time for additional review
feedback though whilst that is going on.

Applied to the testing branch of iio.git.

Note sashiko warning is because you don't have a based on in this cover
letter with appropriate precursor for the export.

Thanks,

Jonathan

> ---
> Changes in v2:
> - set IIO_PROXIMITY channel to scan_index 2 since driver will not handle other
> id properly
> - add IIO_CHAN_INFO_SAMP_FREQ for IIO_PROXIMITY channel
> - isolate missed ALS register calls
> - add commit to use read_avail operation
> - convert to use modern chip info match
>
> Changes in v3:
> - LTR501_INTENSITY_CHANNEL macro adjusted to set predefined info_mask_shared_by_type,
> info_mask_shared_by_type_available and info_mask_shared_by_all_available
> - added info_mask_separate_available and info_mask_shared_by_all_available to
> proximity channel
> - fixed IIO_CHAN_INFO_SCALE for IIO_INTENSITY since table has -1 entries
> - fixed indio_dev->name asignment
> - dropped ltr501_has_als_support helper
> - fixed channel finding in ltr501_trigger_handler
> - isolated more accesses to ALS registers if no_als_support is enabled
>
> Changes in v4:
> - adjusted intensity scale passing
> - int_time and samp_freq converted into 2d arrays
> - for_each_set_bit() + iio_find_channel_from_si() > iio_for_each_active_channel()
>
> Changes in v5
> - fixed als_gain_tbl_len calculation
> - restored use of iio_find_channel_from_si()
>
> This patchset requires change[1] exporting iio_find_channel_from_si() since else
> building as module will fail
>
> [1] https://lore.kernel.org/lkml/20261115083049.46840-1-clamor95@xxxxxxxxx/
> ---
>
> Svyatoslav Ryhel (4):
> iio: light: ltr501: Switch to read_avail() op from manual attribute
> registration
> iio: light: ltr501: Switch to modern match mechanism
> dt-bindings: iio: light: ltr501: Document LTR659 proximity sensor
> iio: light: ltr501: Add support for the LTR-659PS-01 proximity sensor
>
> .../bindings/iio/light/liteon,ltr501.yaml | 1 +
> drivers/iio/light/ltr501.c | 427 +++++++++---------
> 2 files changed, 211 insertions(+), 217 deletions(-)
>