Re: 1.3.94 : if_arp.h

Alan Cox (alan@cymru.net)
Thu, 25 Apr 1996 16:43:04 +0100 (BST)

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Derrik Pates: "Re: broken flock() in linux 1.3.95"
Previous message: William E. Roadcap: "Re: kerneld problem"
In reply to: Ulrich Windl: "Re: 1.3.94 : if_arp.h"

> > - unsigned char ha[MAX_ADDR_LEN]; /* Hardware address */
> > + unsigned char ha[7]; /* Hardware address */
>
> Why not locally defining a constant? I don't like all these magic
> numbers.

The MAX_ADDR_LEN for headers, for network cards an for ARP must all agree
its not a local its a global. Dont make it a number

Next message: Derrik Pates: "Re: broken flock() in linux 1.3.95"
Previous message: William E. Roadcap: "Re: kerneld problem"
In reply to: Ulrich Windl: "Re: 1.3.94 : if_arp.h"