Re: Recently moving back up to the 2.1.28 bandwagon..

Fred Love (flove@atl.mindspring.com)
Thu, 06 Mar 1997 18:27:26 -0500

Bryn Paul Arnold Jones wrote:
>
> On Thu, 6 Mar 1997, Kaitlin Rachael Silver wrote:
>
> >
> > I just upgraded to 2.1.28 from 2.0.29, and now mysteriously
> > letters are being stripped when one telnets to or from my machine. Feel
> > free to telnet to dreamscape.org for an example of what i mean. Is there
> > any "simple fix" out there, where i could download a patch for this?
> >
> > -Kait
> >
>
> Yes, it was a "silly typo" (TM Linus), Linus' fix:
>
> ------8<--- Cut here ---8<------
> diff -u --recursive --new-file v2.1.28/linux/drivers/char/tty_ioctl.c linux/drivers/char/tty_ioctl.c
> --- v2.1.28/linux/drivers/char/tty_ioctl.c Tue Mar 4 10:25:23 1997
> +++ linux/drivers/char/tty_ioctl.c Tue Mar 4 10:18:16 1997
> @@ -503,13 +503,16 @@
> (real_tty->termios_locked,
> (struct termios *) arg);
> case TIOCPKT:
> + {
> + int pktmode;
> +
> if (tty->driver.type != TTY_DRIVER_TYPE_PTY ||
> tty->driver.subtype != PTY_TYPE_MASTER)
> return -ENOTTY;
> - retval = get_user(retval, (int *) arg);
> + retval = get_user(pktmode, (int *) arg);
> if (retval)
> return retval;
> - if (retval) {
> + if (pktmode) {
> if (!tty->packet) {
> tty->packet = 1;
> tty->link->ctrl_status = 0;
> @@ -517,6 +520,7 @@
> } else
> tty->packet = 0;
> return 0;
> + }
> /* These two ioctl's always return success; even if */
> /* the driver doesn't support them. */
> case TCSBRK: case TCSBRKP:
> ------8<--- Cut here ---8<------
>
> Bryn
> --
> PGP key pass phrase forgotten, \ Overload -- core meltdown sequence
> again :( and I don't care ;) | initiated.
> / This space is intentionally left
> | blank, apart from this text ;-)
> \____________________________________

Hi,
I do not understand the above patch. We define a local variable
"pktmode", do not set it, and pass it
by value to get_user. A few lines later we check for pktmode being
non-zero, but it was never set?

Thanks, Fred