Re: MSR support for x86

Stephan Meyer (sensei@wiesel.de)
Fri, 7 Mar 1997 13:39:37 +0100 (MET)


On Mon, 3 Mar 1997, Michel LESPINASSE wrote:
> On Thu, 27 Feb 1997, Stephan Meyer wrote:
>
> > +void msr_init(void) {
> > + int i;
> > + if ((!have_cpuid) && (!(x86_capability & 32))) {
> > + printk("MSR not supported!\n");
> > + return;
> > + }
> > + misc_register(&msr_device);
> > +}
>
> shouldn't this be :
> + if ((!have_cpuid) || (!(x86_capability & 32))) {
>

Many thanks!
This shouldn't make much of a difference, but still, please edit
the file ./drivers/char/msr.c.

Anyway, since there were no more bug-reports, I will submit this patch to
Linus for inclusion in the 2.1.x kernel.

Cheers, Stephan

-----------------------------------------------
Stephan Meyer
+49-89-4301114
Stephan.Meyer@munich.netsurf.de
http://fatman.mathematik.tu-muenchen.de/~meyer/
-----------------------------------------------