Re: New pre-2.0.31 patches..

Matthias Urlichs (smurf@work.smurf.noris.de)
5 Aug 1997 21:58:55 +0200

In dist.linux.kernel, article <870792950.21077@noris.de>,
"Dr. Werner Fink" <werner@suse.de> writes:
> The next missed patch: the atime patch ... one of the most used one on
> big news servers :-)
>
Right...

> The appened patch is extracted out of David's pre-patch.
>
_Please_ don't do this:
> +#ifdef CONFIG_EXT2_NOATIME
> + if (!IS_RDONLY(inode) && !test_opt(sb,NO_ATIME)) {
> +#else
> if (!IS_RDONLY(inode)) {
> +#endif

Being able to match braces is good for you. Typical Unix editors don't
understand C preprocessor statements.

Better:

> - if (!IS_RDONLY(inode)) {
> +#ifdef CONFIG_EXT2_NOATIME
> + if (!IS_RDONLY(inode) && !test_opt(sb,NO_ATIME))
> +#else
> + if (!IS_RDONLY(inode))
> +#endif
> + {

-- 
Matthias Urlichs
noris network GmbH