Bug in Linux PCI for "conf2" type accesses.

Eric Valette (valette@crf.canon.fr)
Wed, 12 Nov 1997 13:12:19 +0100 (CET)

Hi,

Sorry for previous very incomplete mail.

I found another bug in linux 2.0.31 bios32.c file for conf2 type access.
I saw that you fixed the last release for conf1, what shall
I in order to submit it?

I tested succesfully the following patch on a COMPAQ Deskpro XL 400 and
managed to have the network working (onboard lance PCI...).

Thanks for any pointer,

------------------------------------here is the patch---------------

--- bios32.c~ Mon Aug 4 17:38:56 1997
+++ bios32.c Wed Nov 12 12:30:26 1997
@@ -730,7 +730,7 @@
outb (0x00, 0xCFB);
outb (0x00, 0xCF8);
outb (0x00, 0xCFA);
- if (inb (0xCF8) == 0x00 && inb (0xCFB) == 0x00) {
+ if (inb (0xCF8) == 0x00 && inb (0xCFA) == 0x00) {
restore_flags(flags);
printk("pcibios_init: Using configuration type 2\n");
return &pci_direct_conf2;

------------------------------------------------------------------------

BTW : I find that the code scanpci.c that comes with X11R6.3 is more
readable than the code in bios32.c. Maybe we could unify the code...

Have a nice day,

-- 
   __                 
  /  `                   	Eric Valette
 /--   __  o _.          	Canon CRF
(___, / (_(_(__         	Rue de la touche lambert
				35517 Cesson-Sevigne  Cedex


Tel: +33 (0)2 99 87 68 91	Fax: +33 (0)2 99 84 11 30
E-mail: valette@crf.canon.fr