Re: patch against 2.1.78-pre3: HFS, Minix, sound, and SMP warnings and, compilation errors

Trevor Johnson (trevor@jpj.net)
Tue, 6 Jan 1998 13:35:48 -0800 (PST)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

--912357424-1446005579-884122548=:170
Content-Type: TEXT/PLAIN; charset=US-ASCII

a sun:
> /usr/sys/linux/include/linux/hfs_fs.h: In function `hfs_drop_special':
> In file included from filesystems.c:28:
> /usr/sys/linux/include/linux/hfs_fs.h:345: dereferencing pointer to
> incomplete type
> /usr/sys/linux/include/linux/hfs_fs.h:345: dereferencing pointer to
> incomplete type
>
> erk. that's what i get for not realizing that hfs_fs.h can get
> referenced without including hfs.h. in any case, you can move all of
> those inline hfs_drop_*'s into hfs.h instead, and it should fix your
> problem.

I tried following your suggestion but still got some errors (below).
After I moved the hfs_lookup_dentry stuff too, they went away. I haven't
tested this yet, because it hasn't finished compiling. I've attached a
patch.

hfs.h: In function `hfs_drop_special':
In file included from dir_cap.c:25:
hfs.h:497: warning: implicit declaration of function `hfs_lookup_dentry'
hfs.h:497: warning: assignment makes pointer from integer without a cast
hfs.h:500: warning: assignment makes pointer from integer without a cast
/usr/sys/linux/include/linux/hfs_fs.h: At top level:
In file included from dir_cap.c:28:
/usr/sys/linux/include/linux/hfs_fs.h:328: warning: type mismatch with
previous
implicit declaration
hfs.h:497: warning: previous implicit declaration of `hfs_lookup_dentry'
/usr/sys/linux/include/linux/hfs_fs.h:328: warning: `hfs_lookup_dentry'
was previously implicitly declared to return `int'
/usr/sys/linux/include/linux/hfs_fs.h:328: warning: `hfs_lookup_dentry'
was declared implicitly `extern' and later `static'
hfs.h: In function `hfs_cap_drop_dentry':
hfs.h:497: conflicting types for `hfs_lookup_dentry'
/usr/sys/linux/include/linux/hfs_fs.h:328: previous declaration of
`hfs_lookup_dentry'
dir_cap.c:382: warning: assignment makes pointer from integer without a
cast
___
Trevor Johnson

--912357424-1446005579-884122548=:170
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="2.1.78-hfs2.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.980106133548.170C@ppp5.csudh.edu>
Content-Description: 2.1.78-hfs.diff

ZGlmZiAtcnUgbGludXgtMi4xLjc4LWRpc3QvZnMvaGZzL2hmcy5oIGxpbnV4
L2ZzL2hmcy9oZnMuaA0KLS0tIGxpbnV4LTIuMS43OC1kaXN0L2ZzL2hmcy9o
ZnMuaAlUdWUgSmFuICA2IDEzOjI4OjEwIDE5OTgNCisrKyBsaW51eC9mcy9o
ZnMvaGZzLmgJVHVlIEphbiAgNiAxMzoxMzo0MiAxOTk4DQpAQCAtNDg3LDQg
KzQ4NywzOCBAQA0KIC8qIHN5c2RlcC5jICovDQogZXh0ZXJuIGludCBoZnNf
cHJ1bmVfZW50cnkoc3RydWN0IGhmc19jYXRfZW50cnkgKik7DQogDQorc3Rh
dGljIF9faW5saW5lX18gc3RydWN0IGRlbnRyeQ0KKypoZnNfbG9va3VwX2Rl
bnRyeShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBpbnQgbGVuLA0KKyAgICAg
ICAgICAgICAgICAgICBzdHJ1Y3QgZGVudHJ5ICpiYXNlKQ0KK3sNCisgIHN0
cnVjdCBxc3RyIHRoaXM7DQorDQorICB0aGlzLm5hbWUgPSBuYW1lOw0KKyAg
dGhpcy5sZW4gPSBsZW47DQorICB0aGlzLmhhc2ggPSBmdWxsX25hbWVfaGFz
aChuYW1lLCBsZW4pOw0KKw0KKyAgcmV0dXJuIGRfbG9va3VwKGJhc2UsICZ0
aGlzKTsNCit9DQorDQorLyogZHJvcCBhIGRlbnRyeSBmb3Igb25lIG9mIHRo
ZSBzcGVjaWFsIHN1YmRpcmVjdG9yaWVzICovDQorc3RhdGljIF9faW5saW5l
X18gdm9pZCBoZnNfZHJvcF9zcGVjaWFsKGNvbnN0IHN0cnVjdCBoZnNfbmFt
ZSAqbmFtZSwNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IGRlbnRyeSAqYmFzZSwNCisgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRlbnRyeSAqZGVudHJ5
KQ0KK3sNCisgIHN0cnVjdCBkZW50cnkgKmRwYXJlbnQsICpkZTsNCisNCisg
IGRwYXJlbnQgPSBoZnNfbG9va3VwX2RlbnRyeShuYW1lLT5OYW1lLCBuYW1l
LT5MZW4sIGJhc2UpOw0KKyAgaWYgKGRwYXJlbnQpIHsNCisgICAgZGUgPSBo
ZnNfbG9va3VwX2RlbnRyeShkZW50cnktPmRfbmFtZS5uYW1lLCBkZW50cnkt
PmRfbmFtZS5sZW4sDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgZHBh
cmVudCk7DQorICAgIGRwdXQoZHBhcmVudCk7DQorDQorICAgIGlmIChkZSkg
ew0KKyAgICAgIGlmICghZGUtPmRfaW5vZGUpDQorICAgICAgICBkX2Ryb3Ao
ZGUpOw0KKyAgICAgIGRwdXQoZGUpOw0KKyAgICB9DQorICB9DQorfQ0KKw0K
ICNlbmRpZg0KLS0tIGxpbnV4LTIuMS43OC1kaXN0L2luY2x1ZGUvbGludXgv
aGZzX2ZzLmgJVHVlIEphbiAgNiAxMzoyODoyNyAxOTk4DQorKysgbGludXgv
aW5jbHVkZS9saW51eC9oZnNfZnMuaAlUdWUgSmFuICA2IDEzOjEzOjUxIDE5
OTgNCkBAIC0zMjIsNDEgKzMyMiw2IEBADQogCXJldHVybiBsZW47DQogfQ0K
IA0KLXN0YXRpYyBfX2lubGluZV9fIHN0cnVjdCBkZW50cnkgDQotKmhmc19s
b29rdXBfZGVudHJ5KGNvbnN0IGNoYXIgKm5hbWUsIGNvbnN0IGludCBsZW4s
IA0KLQkJICAgc3RydWN0IGRlbnRyeSAqYmFzZSkNCi17DQotICBzdHJ1Y3Qg
cXN0ciB0aGlzOw0KLQ0KLSAgdGhpcy5uYW1lID0gbmFtZTsNCi0gIHRoaXMu
bGVuID0gbGVuOw0KLSAgdGhpcy5oYXNoID0gZnVsbF9uYW1lX2hhc2gobmFt
ZSwgbGVuKTsNCi0NCi0gIHJldHVybiBkX2xvb2t1cChiYXNlLCAmdGhpcyk7
DQotfQ0KLQ0KLS8qIGRyb3AgYSBkZW50cnkgZm9yIG9uZSBvZiB0aGUgc3Bl
Y2lhbCBzdWJkaXJlY3RvcmllcyAqLw0KLXN0YXRpYyBfX2lubGluZV9fIHZv
aWQgaGZzX2Ryb3Bfc3BlY2lhbChjb25zdCBzdHJ1Y3QgaGZzX25hbWUgKm5h
bWUsDQotCQkJCQlzdHJ1Y3QgZGVudHJ5ICpiYXNlLA0KLQkJCQkJc3RydWN0
IGRlbnRyeSAqZGVudHJ5KQ0KLXsNCi0gIHN0cnVjdCBkZW50cnkgKmRwYXJl
bnQsICpkZTsNCi0gIA0KLSAgZHBhcmVudCA9IGhmc19sb29rdXBfZGVudHJ5
KG5hbWUtPk5hbWUsIG5hbWUtPkxlbiwgYmFzZSk7DQotICBpZiAoZHBhcmVu
dCkgew0KLSAgICBkZSA9IGhmc19sb29rdXBfZGVudHJ5KGRlbnRyeS0+ZF9u
YW1lLm5hbWUsIGRlbnRyeS0+ZF9uYW1lLmxlbiwNCi0JCQkgICBkcGFyZW50
KTsNCi0gICAgZHB1dChkcGFyZW50KTsNCi0NCi0gICAgaWYgKGRlKSB7DQot
ICAgICAgaWYgKCFkZS0+ZF9pbm9kZSkNCi0JZF9kcm9wKGRlKTsNCi0gICAg
ICBkcHV0KGRlKTsNCi0gICAgfQ0KLSAgfQ0KLX0NCi0NCiAjZW5kaWYNCiAj
ZW5kaWYgLyogX19LRVJORUxfXyAqLw0KLQ0KICNlbmRpZg0K
--912357424-1446005579-884122548=:170--