Re: MD Boot patch V1.2 with config support

Jakub Jelinek (jj@sunsite.ms.mff.cuni.cz)
Wed, 14 Jan 1998 17:54:11 +0100 (MET)

> +#ifdef CONFIG_MD_BOOT
> + extern void md_setup_drive(void) __init;
> +#endif
...>
> +#ifdef CONFIG_MD_BOOT
> +extern dev_t name_to_dev_t(char *line) __init;
> +#endif
...
> +#ifdef CONFIG_MD_BOOT
> +__initfunc(void md_setup_drive(void))
> +{
> + if(md_setup_args.set)
> + do_md_setup(md_setup_args.str, md_setup_args.ints);
> +}
> +#endif

Just a comment. You don't need to put the __init in all function prototypes,
just one is enough (the one where you actually define the function).
Neither gcc nor binutils need to have some knowledge about the section an
external function will be in, it is a call all the time.

Cheers,
Jakub
___________________________________________________________________
Jakub Jelinek | jj@sunsite.mff.cuni.cz | http://sunsite.mff.cuni.cz
Administrator of SunSITE Czech Republic, MFF, Charles University
___________________________________________________________________
Ultralinux - first 64bit OS to take full power of the UltraSparc
Linux version 2.0.32 on a sparc machine (291.64 BogoMips).
___________________________________________________________________