Re: 2.1.80 miscellanea

Thomas Sailer (sailer@ife.ee.ethz.ch)
Thu, 22 Jan 1998 19:02:37 +0100

> > if (__copy_to_user(arg, &info, sizeof(info)))
> > return -EFAULT;
>
> Also, I recommend changing __copy_to_user to copy_to_user for the sake
> of safety.

Feel free to post a patch if it makes you feel more comfortable -
now that we have out-of-line get_user this would probably not
even make the size of the driver bigger.

Note however that this would not have helped the above problem -
1 is a perfectly valid user space pointer

Tom