pci_read_config_byte in 2.1.85

Martin Mares (mj@ucw.cz)
Wed, 4 Feb 1998 09:53:40 +0100


Hi,

I've looked at the pcibios_read_config_byte() change in 2.1.85 which overrides
IRQ information read from PCI devices and overrides it by translated values
for APIC IRQ's. IMHO it is not the right solution to the problem: no drivers
should read the interrupt number from config registers directly (if they do,
they are broken and should be fixed as this scheme already breaks on the Ultra),
they should use pci_dev->irq instead which can be set by arch-dependent fixup
function. I propose moving this translation to i386 pci_bios_fixup(), are
there any objections?

Have a nice fortnight

-- 
Martin `MJ' Mares   <mj@ucw.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"Current root password is "p3s5vwF50". Keep secret."