Re: Linux-2.1.85: replacement PATCH for ibmmca

Michael Elizabeth Chastain (mec@shout.net)
Thu, 5 Feb 1998 11:52:15 -0600


Hi Adam,

> + dep_tristate 'IBMMCA SCSI support' CONFIG_SCSI_IBMMCA $CONFIG_SCSI
> + if [ "$CONFIG_SCSI_IBMMCA" != "n" ]; then

There's a problem with this. At the beginning of execution,
CONFIG_SCSI_IBMMCA has the value "". Menuconfig constructs its menus
before interpreting any dep_tristate lines, so this test will result
in the construction of a spurious menu.

The right way to test is:

if [ "$CONFIG_SCSI_IBMMCA" = "y" -o "$CONFIG_SCSI_IBMMCA = "m" ]; then

Trevor Johnson has a patch that fixes all the instances of this in
all the config.in and Config.in files.

Regards,

Michael Chastain
<mailto:mec@shout.net>
"love without fear"