Re: XT hard disk support

Andrzej Krzysztofowicz (ankry@idk.com.pl)
Wed, 8 Apr 1998 11:27:09 +0200 (MET DST)


> > any1 tried to compile "XT harddisk support" as module ? I don't think
> > it will succeed! Anyway in drivers/block/xd.c:
> >
> > static int xd[5] = { -1,-1,-1,-1, };
>
> It is needed only by init_module() which passes it to xd_setup().
> xd_setup() sets other variables to apropriate values.
> xd[] shuoldn't be used elsewhere.

Sorry, you are of cource right. My previous xd.c patch was buggy.
The following patch should reverse the bug:

diff -u --recursive --new-file v2.1.92/linux/drivers/block/xd.c linux/drivers/block/xd.c
--- v2.1.92/linux/drivers/block/xd.c Sun Jan 4 10:40:15 1998
+++ linux/drivers/block/xd.c Sat Apr 4 09:36:10 1998
@@ -706,8 +706,8 @@
switch (address) {
case 0x00000:
case 0xC8000: break; /*initial: 0x320 */
- case 0xCA000: if (xd[3]<=0) xd_iobase = 0x324;
+ case 0xCA000: xd_iobase = 0x324;
case 0xD0000: /*5150CX*/
case 0xD8000: break; /*5150CX & 5150XL*/
default: printk("xd_dtc_init_controller: unsupported BIOS address %06x\n",address);

--
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone: (48)(58) 347 14 61            fax: (48)(58) 347 28 21
Faculty of Applied Phys.& Maths, Technical University of Gdansk, Poland

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu