Re: [PATCH] Fix bad typo that sabotates O_TRUNC

ak@muc.de
Fri, 10 Apr 1998 01:50:54 +0200

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Michael Remski: "2.1.94, SMP on UP system"
Previous message: Thomas Pornin: "Re: 2.1.94 modules catch-22"

On Fri, Apr 10, 1998 at 01:01:30AM +0200, Linus Torvalds wrote:
>
>
> On Fri, 10 Apr 1998 ak@muc.de wrote:
> >
> > I found a bad typo in 2.1.94 do_open() - O_TRUNC is always ignored because
> > of an obvious typo (flag&O_TRUNC instead of flags&O_TRUNC). O_TRUNC never
> > works, because O_ACCMODE is smaller than O_TRUNC.
>
> flags/flag should contain the same information apart from the low two bits
> (which is the access mode). So I don't think this was a bug.

You're right. I misread the code.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

Next message: Michael Remski: "2.1.94, SMP on UP system"
Previous message: Thomas Pornin: "Re: 2.1.94 modules catch-22"