Re: IDE Driver update for SMP

David S. Miller (davem@dm.cobaltmicro.com)
Thu, 9 Apr 1998 19:52:08 -0700


Date: Thu, 09 Apr 1998 21:50:28 -0400
From: mlord <mlord@pobox.com>

Read this part of your patch carefully... For the restore_flags()
change the comment is correct, but the leading underscores are missing
;-)))

diff -u --recursive --new-file --exclude=.* linux-2.1.94/drivers/block/ns87415.c linux/drivers/block/ns87415.c
--- linux-2.1.94/drivers/block/ns87415.c Mon Apr 6 22:16:07 1998
+++ linux/drivers/block/ns87415.c Thu Apr 9 16:23:09 1998
@@ -35,7 +35,8 @@
struct pci_dev *dev = hwif->pci_dev;
unsigned long flags;

- save_flags(flags); cli();
+ __save_flags(flags); /* local CPU only */
+ __cli(); /* local CPU only */
new = *old;

/* adjust IRQ enable bit */
@@ -56,7 +57,7 @@
*old = new;
(void) pci_write_config_dword(dev, 0x40, new);
}
- restore_flags(flags);
+ restore_flags(flags); /* local CPU only */
}

static void ns87415_selectproc (ide_drive_t *drive)
@@ -66,33 +67,25 @@

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu