On Fri, Apr 24, 1998 at 10:25:12PM -0700, Linus Torvalds wrote:
> Actually, upon looking at this, the way I'd like you to test these is to
> make enable_ioapic_irq() look like:
>
> void enable_ioapic_irq (unsigned int irq)
> {
> unsigned long flags;
>
> spin_lock_irqsave(&irq_controller_lock, flags);
> disabled_irq[irq] = 0;
> spin_unlock_irqrestore(&irq_controller_lock, flags);
> }
>
> (ie avoid all the clever self-calling stuff: the IO-APIC is a fragile
> beats and can get upset if it has too many pending interrupts). And leave
> "disable_ioapic_irq()" the way it is.
>
Whatever else you added to this patch is munging up the code. I'll
cc it to the list for David and co.
-- ---------------------------------------------------------------------- Dr. Bill Broadhurst | Independent contract Engineer. (619)296-3710 | BIOS, Firmware, & Diagnostics. bbroad@CX492564-a.dt1.sdca.home.com | Finger for PGP 5.0 public key. ----------------------------------------------------------------------- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu