Re: Possible bogus sti() in sched.c

Rogier Wolff (R.E.Wolff@BitWizard.nl)
Tue, 26 May 1998 08:30:51 +0200 (MET DST)

Linus Torvalds wrote:
>
>
>
> On Mon, 25 May 1998, Paul Gortmaker wrote:
> >
> > In run_old_timers() there is an sti() after calling any
> > registered timer function that looks suspicious. (sched.c)
>
> It's there to just make sure no timer function has left the interrupts
> disabled. Similar code exists in the interrupt handler stuff. I guess it's
> just unnecessary paranoia..

In that case I'd make it into a
save_flags (flags);
if (flags & ....)
bug_them ();

Regards,

Roger. 

-- 
If it's there and you can see it, it's REAL      |___R.E.Wolff@BitWizard.nl  |
If it's there and you can't see it, it's TRANSPARENT |  Tel: +31-15-2137555  |
If it's not there and you can see it, it's VIRTUAL   |__FAX:_+31-15-2138217  |
If it's not there and you can't see it, it's GONE! -- Roy Wilks, 1983  |_____|


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu