Re: serial problems (was Re: serial (PPP) stomping on parport?)

D.A. Harris (rodmur@ecst.csuchico.edu)
Wed, 10 Jun 1998 12:54:14 -0700

On Wed, Jun 10, 1998 at 10:00:46AM -0700, Derrik wrote:
> I tried removing the new_serial.xmit_fifo_size check, and so far I'm not
> having any problems. setserial set up the port correctly, and everything
> seems to be happy. Maybe this should have been something like
> (new_serial.xmit_fifo_size < 0)?
>
> Derrik Pates
> dpates@kalifornia.com
> dpates@acm.org
>

Tried this, and it works for me. Able to configure the ports just fine under
2.1.105. Here's a patch for easier reference:

*** /usr/src/linux-2.1.104/drivers/char/serial.c Mon May 25 10:32:52 1998
--- serial.c Wed Jun 10 12:12:22 1998
***************
*** 1661,1669 ****

if ((new_serial.irq >= NR_IRQS) || (new_serial.port > 0xffff) ||
(new_serial.type < PORT_UNKNOWN) ||
(new_serial.type > PORT_MAX) ||
! (new_serial.xmit_fifo_size == 0)) {
return -EINVAL;
}

/* Make sure address is not already in use */
--- 1661,1669 ----

if ((new_serial.irq >= NR_IRQS) || (new_serial.port > 0xffff) ||
(new_serial.type < PORT_UNKNOWN) ||
(new_serial.type > PORT_MAX) ||
! (new_serial.xmit_fifo_size < 0)) {
return -EINVAL;
}

/* Make sure address is not already in use */

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dale Harris  <rodmur@csuchico.edu>   PGP KeyID: E26EC5FD      
http://www.ecst.csuchico.edu/~rodmur/
|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|+|


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu