Re: [OT] Re: Cosmetic Changes: ensuring decency of the Linux Kernel Source.

Jakub Jelinek (jj@sunsite.ms.mff.cuni.cz)
Thu, 15 Oct 1998 16:22:02 +0200 (MET DST)

>
>
> On Wed, 14 Oct 1998, Helge Hafting wrote:
>
> > >Jauder Ho wrote:
> > >>
> > >> well actually if you look there is a print statement that says "Tell DaveM
> > >> that he fucked up" so there is at least one print statement that I can
> > >> see.
> >
> > The correct action here would be to fix whatever it is DaveM has fucked
> > up. Then remove the no longer needed printk().
>
> if you actually read the source, it is very likely that say EGCS optimizes
> that panic away completely, because it's impossible to reach it.

Well, it does not, and even if it did, it would probably keep the string
constant in the resulting object (as Martin Mares has not implemented yet
the garbage collector for unused constants he proposed).
Try
if (0) bar("unused string");

and unused string will be in rodata anyway.

Cheers,
Jakub
___________________________________________________________________
Jakub Jelinek | jj@sunsite.mff.cuni.cz | http://sunsite.mff.cuni.cz
Administrator of SunSITE Czech Republic, MFF, Charles University
___________________________________________________________________
Ultralinux - first 64bit OS to take full power of the UltraSparc
Linux version 2.1.125 on a sparc64 machine (498.80 BogoMips).
___________________________________________________________________

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/