--8323328-2138106437-910776071=:755
Content-Type: TEXT/PLAIN; charset=US-ASCII
The attached patch should fix ncr53c8xx-3.1a driver misbehaviour when the
number of configured tags for a device is larger than the maximum
configured for the driver.
Using #ifXXX stuff was not enough to fix this problem, since the device
queue depths are configurable from the boot command line using something
like:
ncr53c8xx=tags:16/t3q5-t4q12/t0q14
The fix is just some checks against driver tags capacity performed at
run-time.
The patch is against kernel 2.1.127. If you need to use it against other
kernels, you may have to remove from the patch the diff section that
applies to Configure.help kernel file.
BTW, the 896 driver needs a similar fix for it to be also protected
against misconfigs, but the attached patch does not apply to this driver.
I will made the appropriate patch available at ftp.tux.org/pub/roudier/896
soon.
Since it has been proven that my personal tests are far from guaranteeing
things are good enough for the kernel main-stream, could you, please, give
this patch a try by forcing misconfigs statically and dynamically from the
boot command line and let me know if you have experienced problems. You
may want to use private emails or just send a copy to the linux-scsi list
if you think your report is to be shared.
Thanks in advance for your help.
Regards,
Gerard.
--8323328-2138106437-910776071=:755
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ncr53c8xx-3.1a-to-3.1b-for-linux-2.1.127.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.95.981111102111.755B@localhost>
Content-Description: 3.1a-to-3.1b-for-2.1.127
LS0tIGxpbnV4L2RyaXZlcnMvc2NzaS9DaGFuZ2VMb2cubmNyNTNjOHh4Lk9S
SUcJU3VuIE5vdiAgOCAxNTo1NzowOSAxOTk4DQorKysgbGludXgvZHJpdmVy
cy9zY3NpL0NoYW5nZUxvZy5uY3I1M2M4eHgJV2VkIE5vdiAxMSAwOTo1NDoz
MCAxOTk4DQpAQCAtMSwzICsxLDkgQEANCitNb24gTm92IDExICAxMDowMCAx
OTk4IEdlcmFyZCBSb3VkaWVyIChncm91ZGllckBjbHViLWludGVybmV0LmZy
KQ0KKwkqIHJldmlzaW9uIDMuMWINCisJLSBUaGUgZHJpdmVyIHdhcyB1bmhh
cHB5IHdoZW4gY29uZmlndXJlZCB3aXRoIGRlZmF1bHRfdGFncyA+IE1BWF9U
QUdTDQorCSAgSG9wZWZ1bGx5IGRvdWJseS1maXhlZC4NCisJLSBVcGRhdGUg
dGhlIENvbmZpZ3VyZS5oZWxwIGRyaXZlciBzZWN0aW9uIHRoYXQgc3BlYWtz
IG9mIFRBR1MuDQorDQogV2VkIE9jdCAyMSAyMTowMCAxOTk4IEdlcmFyZCBS
b3VkaWVyIChncm91ZGllckBjbHViLWludGVybmV0LmZyKQ0KIAkqIHJldmlz
aW9uIDMuMWENCiAJLSBDaGFuZ2VzIGZyb20gRWRkaWUgRG9zdCBmb3IgU3Bh
cmMgYW5kIEFscGhhOg0KLS0tIGxpbnV4L2RyaXZlcnMvc2NzaS9uY3I1M2M4
eHguaC5PUklHCVN1biBOb3YgIDggMTU6NTY6NTAgMTk5OA0KKysrIGxpbnV4
L2RyaXZlcnMvc2NzaS9uY3I1M2M4eHguaAlTdW4gTm92ICA4IDIxOjQ3OjA2
IDE5OTgNCkBAIC00NSw3ICs0NSw3IEBADQogLyoNCiAqKglOYW1lIGFuZCBy
ZXZpc2lvbiBvZiB0aGUgZHJpdmVyDQogKi8NCi0jZGVmaW5lIFNDU0lfTkNS
X0RSSVZFUl9OQU1FCQkibmNyNTNjOHh4IC0gcmV2aXNpb24gMy4xYSINCisj
ZGVmaW5lIFNDU0lfTkNSX0RSSVZFUl9OQU1FCQkibmNyNTNjOHh4IC0gcmV2
aXNpb24gMy4xYiINCiANCiAvKg0KICoqCUNoZWNrIHN1cHBvcnRlZCBMaW51
eCB2ZXJzaW9ucw0KLS0tIGxpbnV4L2RyaXZlcnMvc2NzaS9uY3I1M2M4eHgu
Yy5PUklHCVN1biBOb3YgIDggMTU6NTY6NTYgMTk5OA0KKysrIGxpbnV4L2Ry
aXZlcnMvc2NzaS9uY3I1M2M4eHguYwlUdWUgTm92IDEwIDAwOjEyOjExIDE5
OTgNCkBAIC03Myw3ICs3Myw3IEBADQogKi8NCiANCiAvKg0KLSoqCU9jdG9i
ZXIgMjEgMTk5OCwgdmVyc2lvbiAzLjFhDQorKioJTm92ZW1iZXIgMTEgMTk5
OCwgdmVyc2lvbiAzLjFiDQogKioNCiAqKglTdXBwb3J0ZWQgU0NTSS1JSSBm
ZWF0dXJlczoNCiAqKgkgICAgU3luY2hyb25vdXMgbmVnb3RpYXRpb24NCkBA
IC00MzE5LDcgKzQzMTksNyBAQA0KICNlbmRpZg0KIAkJCXRwLT51c3JzeW5j
ID0gZHJpdmVyX3NldHVwLmRlZmF1bHRfc3luYzsNCiAJCQl0cC0+dXNyd2lk
ZSA9IGRyaXZlcl9zZXR1cC5tYXhfd2lkZTsNCi0JCQl0cC0+dXNydGFncyA9
IGRyaXZlcl9zZXR1cC5kZWZhdWx0X3RhZ3M7DQorCQkJdHAtPnVzcnRhZ3Mg
PSBTQ1NJX05DUl9NQVhfVEFHUzsNCiAJCQlpZiAoIWRyaXZlcl9zZXR1cC5k
aXNjb25uZWN0aW9uKQ0KIAkJCQlucC0+dGFyZ2V0W2ldLnVzcmZsYWcgPSBV
Rl9OT0RJU0M7DQogCQl9DQpAQCAtODIwOCw2ICs4MjA4LDEyIEBADQogCWlm
IChscCkgew0KIAkJWFBUX1FVRUhFQUQgKnFwOw0KIAkJLyoNCisJCSoqCUtl
ZXAgZnJvbSB1c2luZyBtb3JlIHRhZ3MgdGhhbiB3ZSBjYW4gaGFuZGxlLg0K
KwkJKi8NCisJCWlmIChscC0+dXNldGFncyAmJiBscC0+YnVzeWNjYnMgPj0g
bHAtPm1heG54cykNCisJCQlyZXR1cm4gKGNjYl9wKSAwOw0KKw0KKwkJLyoN
CiAJCSoqCUFsbG9jYXRlIGEgbmV3IENDQiBpZiBuZWVkZWQuDQogCQkqLw0K
IAkJaWYgKHhwdF9xdWVfZW1wdHkoJmxwLT5mcmVlX2NjYnEpKQ0KQEAgLTEw
MDcyLDE5ICsxMDA3OCwyMCBAQA0KIAkJbHAgPSB0cC0+bHBbZGV2aWNlLT5s
dW5dOw0KIA0KIAkJLyoNCi0JCSoqCURvbm5vdCB1c2UgbW9yZSB0aGFuIG91
ciBtYXhpbXVtLg0KIAkJKioJU2VsZWN0IHF1ZXVlIGRlcHRoIGZyb20gZHJp
dmVyIHNldHVwLg0KIAkJKioJRG9ubm90IHVzZSBtb3JlIHRoYW4gY29uZmln
dXJlZCBieSB1c2VyLg0KIAkJKioJVXNlIDIgZm9yIGRldmljZXMgdGhhdCBk
b25ub3Qgc3VwcG9ydCB0YWdzLg0KIAkJKioJVXNlIGF0IGxlYXN0IDIuDQor
CQkqKglEb25ub3QgdXNlIG1vcmUgdGhhbiBvdXIgbWF4aW11bS4NCiAJCSov
DQotCQlkZXZpY2UtPnF1ZXVlX2RlcHRoID0gU0NTSV9OQ1JfTUFYX1RBR1M7
DQogCQlkZXZpY2UtPnF1ZXVlX2RlcHRoID0NCiAJCQlkZXZpY2VfcXVldWVf
ZGVwdGgobnAsIGRldmljZS0+aWQsIGRldmljZS0+bHVuKTsNCiAJCWlmIChk
ZXZpY2UtPnF1ZXVlX2RlcHRoID4gdHAtPnVzcnRhZ3MpDQogCQkJZGV2aWNl
LT5xdWV1ZV9kZXB0aCA9IHRwLT51c3J0YWdzOw0KIAkJaWYgKCFkZXZpY2Ut
PnRhZ2dlZF9zdXBwb3J0ZWQgfHwgZGV2aWNlLT5xdWV1ZV9kZXB0aCA8IDIp
DQogCQkJZGV2aWNlLT5xdWV1ZV9kZXB0aCA9IDI7DQorCQlpZiAoZGV2aWNl
LT5xdWV1ZV9kZXB0aCA+IFNDU0lfTkNSX01BWF9UQUdTKQ0KKwkJCWRldmlj
ZS0+cXVldWVfZGVwdGggPSBTQ1NJX05DUl9NQVhfVEFHUzsNCiANCiAJCS8q
DQogCQkqKglTaW5jZSB0aGUgcXVldWUgZGVwdGggaXMgbm90IHR1bmFibGUg
dW5kZXIgTGludXgsDQotLS0gbGludXgvRG9jdW1lbnRhdGlvbi9Db25maWd1
cmUuaGVscC5PUklHCVN1biBOb3YgIDggMjA6MTM6MjEgMTk5OA0KKysrIGxp
bnV4L0RvY3VtZW50YXRpb24vQ29uZmlndXJlLmhlbHAJVHVlIE5vdiAxMCAw
MDoxMDo1NiAxOTk4DQpAQCAtMzc0MCw5ICszNzQwLDggQEANCiAgIHRoaXMg
ZmVhdHVyZSwgZW50ZXIgMCBvciAxIGhlcmUgKGl0IGRvZXNuJ3QgbWF0dGVy
IHdoaWNoKS4NCiANCiAgIFRoZSBkZWZhdWx0IHZhbHVlIGlzIDggYW5kIHNo
b3VsZCBiZSBzdXBwb3J0ZWQgYnkgbW9zdCBoYXJkIGRpc2tzLg0KLSAgVGhp
cyBvcHRpb24gaGFzIG5vIGVmZmVjdCBmb3IgYWRhcHRlcnMgd2l0aCBOVlJB
TSwgc2luY2UgdGhlIGRyaXZlciANCi0gIHdpbGwgZ2V0IHRoaXMgaW5mb3Jt
YXRpb24gZnJvbSB0aGUgdXNlciBzZXQtdXAuIEl0IGFsc28gY2FuIGJlIA0K
LSAgb3ZlcnJpZGRlbiB1c2luZyBhIGJvb3Qgc2V0dXAgb3B0aW9uLCBhcyBm
b2xsb3dzIChleGFtcGxlKToNCisgIFRoaXMgdmFsdWUgY2FuIGJlIG92ZXJy
aWRkZW4gZnJvbSB0aGUgYm9vdCBjb21tYW5kIGxpbmUgdXNpbmcgdGhlIA0K
KyAgJ3RhZ3MnIG9wdGlvbiBhcyBmb2xsb3dzIChleGFtcGxlKToNCiAgICdu
Y3I1M2M4eHg9dGFnczo0L3QydDNxMTYvdDB1MnExMCcgd2lsbCBzZXQgZGVm
YXVsdCBxdWV1ZSBkZXB0aCB0byA0LCANCiAgIHNldCBxdWV1ZSBkZXB0aCB0
byAxNiBmb3IgdGFyZ2V0IDIgYW5kIHRhcmdldCAzIG9uIGNvbnRyb2xsZXIg
MCBhbmQgDQogICBzZXQgcXVldWUgZGVwdGggdG8gMTAgZm9yIHRhcmdldCAw
IC8gbHVuIDIgb24gY29udHJvbGxlciAxLg0KQEAgLTM3NTcsMTQgKzM3NTYs
MTIgQEANCiBDT05GSUdfU0NTSV9OQ1I1M0M4WFhfTUFYX1RBR1MNCiAgIFRo
aXMgb3B0aW9uIGFsbG93cyB5b3UgdG8gc3BlY2lmeSB0aGUgbWF4aW11bSBu
dW1iZXIgb2YgY29tbWFuZHMNCiAgIHRoYXQgY2FuIGJlIHF1ZXVlZCB0byBh
bnkgZGV2aWNlLCB3aGVuIHRhZ2dlZCBjb21tYW5kIHF1ZXVpbmcgaXMNCi0g
IHBvc3NpYmxlLiAgVGhlIGRlZmF1bHQgdmFsdWUgaXMgMzIuIE1pbmltdW0g
aXMgMiwgbWF4aW11bSBpcyA2NC4NCi0gIEZvciB2YWx1ZSBsZXNzIHRoYW4g
MzIsIHRoaXMgb3B0aW9uIG9ubHkgc2F2ZXMgYSBsaXR0bGUgbWVtb3J5IA0K
LSAgKDgqNyooMzItTUFYVEFHUykgYnl0ZXMpLCBzbyB1c2luZyBsZXNzIHRo
YW4gMzIgaXNuJ3Qgd29ydGggaXQuDQotICBGb3IgdmFsdWUgZ3JlYXRlciB0
aGFuIDMyLCBsYXRlbmN5IG9uIHJlc2VsZWN0aW9uIHdpbGwgYmUgaW5jcmVh
c2VkIA0KLSAgYnkgMSBvciAyIG1pY3JvLXNlY29uZHMuIFNvLCB0aGUgbm9y
bWFsIGFuc3dlciBoZXJlIGlzIHRvIGdvIHdpdGggdGhlIA0KLSAgZGVmYXVs
dCB2YWx1ZSAzMiB1bmxlc3MgeW91IGFyZSB1c2luZyB2ZXJ5IGxhcmdlIGhh
cmQgZGlza3Mgd2l0aCANCi0gIGxhcmdlIGNhY2hlICg+PSAxTUIpIHRoYXQg
YXJlIGFibGUgdG8gdGFrZSBhZHZhbnRhZ2Ugb2YgbW9yZSB0aGFuIA0KLSAg
MzIgdGFnZ2VkIGNvbW1hbmRzLg0KKyAgcG9zc2libGUuIFRoZSBkZWZhdWx0
IHZhbHVlIGlzIDMyLiBNaW5pbXVtIGlzIDIsIG1heGltdW0gaXMgNjQuDQor
ICBNb2Rlcm4gaGFyZCBkaXNrcyBhcmUgYWJsZSB0byBzdXBwb3J0IDY0IHRh
Z3MgYW5kIGV2ZW4gbW9yZSwgYnV0IA0KKyAgZG9ubm90IHNlZW0gdG8gYmUg
ZmFzdGVyIHdoZW4gbW9yZSB0aGFuIDMyIHRhZ3MgYXJlIGJlaW5nIHVzZWQu
DQorICBTbywgdGhlIG5vcm1hbCBhbnN3ZXIgaGVyZSBpcyB0byBnbyB3aXRo
IHRoZSBkZWZhdWx0IHZhbHVlIDMyIHVubGVzcyANCisgIHlvdSBhcmUgdXNp
bmcgdmVyeSBsYXJnZSBoYXJkIGRpc2tzIHdpdGggbGFyZ2UgY2FjaGUgKD49
IDFNQikgdGhhdCANCisgIG1heSBiZSBhYmxlIHRvIHRha2UgYWR2YW50YWdl
IG9mIG1vcmUgdGhhbiAzMiB0YWdnZWQgY29tbWFuZHMuDQogDQogICBUaGVy
ZSBpcyBubyBzYWZlIG9wdGlvbiBhbmQgdGhlIGRlZmF1bHQgYW5zd2VyIGlz
IHJlY29tbWVuZGVkLg0KIA0K
--8323328-2138106437-910776071=:755--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/