Shouldn't all seven references to MOD_DEC_USE_COUNT within rs_open be
removed? As I see from tty_open (in tty_io.c), rs_close is always called
after an unsuccessful rs_open. As rs_close always calls
MOD_DEC_USE_COUNT, there is no need (and it's even harmful) to do this
from rs_open.
No, because rs_close() only calls MOD_DEC_USE_COUNT if tty->driver_data
is non-NULL.
The change I submitted was the simplest set of changes which fix the
problem, without completely revamping how the module in-use counter
works for the serial driver.
- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/