Kernel version : 129ac5
Platform : i386 (gcc)
Affected files : drivers/char/serial.c
Description of the problem
--------------------------
line 1997: rs_interrupt only declared if CONFIG_SERIAL_SHARE_IRQ is;
fixed the same way as handled around line 854.
Suggested fix
-------------
diff -u -r -N linux/drivers/char/serial.c /usr/src/linux/drivers/char/serial.c
--- linux/drivers/char/serial.c Fri Nov 13 18:44:25 1998
+++ /usr/src/linux/drivers/char/serial.c Fri Nov 13 19:05:09 1998
@@ -1987,7 +1987,8 @@
request_region(multi->port4,1,"serial(multiport4)");
now_multi = (multi->port1 != 0);
-
+
+#ifdef CONFIG_SERIAL_SHARE_IRQ
if (IRQ_ports[state->irq]->next_port &&
(was_multi != now_multi)) {
free_irq(state->irq, NULL);
@@ -2003,7 +2004,7 @@
"driver!!\n");
}
}
-
+#endif /* CONFIG_SERIAL_SHARE_IRQ */
return 0;
}
#endif
Compiler output + config-file
-----------------------------
>From root@pentafluge.home.nl Wed Nov 25 21:49:50 1998
Delivered-To: arjan@toad.stack.nl
Received: from amadeus.home.nl (n25.dial.tue.nl [131.155.209.24])
by toad.stack.nl (VMailer) with ESMTP
id 4710B9655; Wed, 25 Nov 1998 21:49:43 +0100 (CET)
Received: from pentafluge.home.nl (really [10.1.2.3]) by amadeus.home.nl
via in.smtpd with esmtp (ident root using rfc1413)
id <m0zinmx-00015oC@amadeus.home.nl> (Debian Smail3.2.0.101)
for <arjan@toad.stack.nl>; Wed, 25 Nov 1998 23:51:59 +0100 (CET)
Received: by pentafluge.home.nl
via sendmail from stdin
id <m0zikq9-000BosC@pentafluge.home.nl> (Debian Smail3.2.0.101)
for arjan@toad.stack.nl; Wed, 25 Nov 1998 20:43:05 +0100 (CET)
Message-Id: <m0zikq9-000BosC@pentafluge.home.nl>
From: root@pentafluge.home.nl (root)
Subject: _KERNEL_129ac5
Date: Wed, 25 Nov 1998 20:43:05 +0100 (CET)
To: arjan@toad.stack.nl
X-Mailer: fastmail [version 2.4ME+ PL39 (25)]
make[1]: Entering directory `/usr/src/linux/kernel'
make[2]: Entering directory `/usr/src/linux/kernel'
make[1]: Entering directory `/usr/src/linux/drivers'
make[2]: Entering directory `/usr/src/linux/drivers/block'
make[3]: Entering directory `/usr/src/linux/drivers/block'
genhd.c: In function `msdos_partition':
genhd.c:403: warning: `bsd_maxpart' might be used uninitialized in this function
hd.c:786: warning: initialization from incompatible pointer type
hd.c:788: warning: initialization from incompatible pointer type
make[2]: Entering directory `/usr/src/linux/drivers/char'
make[3]: Entering directory `/usr/src/linux/drivers/char/ftape'
make[4]: Entering directory `/usr/src/linux/drivers/char/ftape/lowlevel'
make[5]: Entering directory `/usr/src/linux/drivers/char/ftape/lowlevel'
make[4]: Entering directory `/usr/src/linux/drivers/char/ftape/zftape'
make[5]: Entering directory `/usr/src/linux/drivers/char/ftape/zftape'
make[4]: Entering directory `/usr/src/linux/drivers/char/ftape'
make[3]: Entering directory `/usr/src/linux/drivers/char'
serial.c: In function `set_multiport_struct':
serial.c:1997: `rs_interrupt' undeclared (first use this function)
serial.c:1997: (Each undeclared identifier is reported only once
serial.c:1997: for each function it appears in.)
serial.c:1938: warning: `handler' might be used uninitialized in this function
make[3]: *** [serial.o] Error 1
make[2]: *** [first_rule] Error 2
make[1]: *** [_subdir_char] Error 2
make: *** [_dir_drivers] Error 2
#
# Automatically generated make config: don't edit
#
#
# Code maturity level options
#
# CONFIG_EXPERIMENTAL is not set
#
# Processor type and features
#
# CONFIG_M386 is not set
# CONFIG_M486 is not set
CONFIG_M586=y
# CONFIG_M686 is not set
CONFIG_MATH_EMULATION=y
#
# Loadable module support
#
CONFIG_MODULES=y
# CONFIG_MODVERSIONS is not set
CONFIG_KMOD=y
#
# General setup
#
CONFIG_NET=y
CONFIG_PCI=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
CONFIG_PCI_QUIRKS=y
# CONFIG_PCI_OLD_PROC is not set
# CONFIG_MCA is not set
CONFIG_SYSVIPC=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_SYSCTL=y
CONFIG_BINFMT_AOUT=m
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=y
CONFIG_PARPORT=y
# CONFIG_PARPORT_PC is not set
CONFIG_APM=y
CONFIG_APM_IGNORE_USER_SUSPEND=y
# CONFIG_APM_DO_ENABLE is not set
# CONFIG_APM_CPU_IDLE is not set
# CONFIG_APM_DISPLAY_BLANK is not set
# CONFIG_APM_POWER_OFF is not set
CONFIG_APM_IGNORE_MULTIPLE_SUSPEND=y
#
# Plug and Play support
#
# CONFIG_PNP is not set
#
# Block devices
#
CONFIG_BLK_DEV_FD=y
CONFIG_BLK_DEV_IDE=m
#
# Please see Documentation/ide.txt for help/info on IDE drives
#
CONFIG_BLK_DEV_HD_IDE=y
# CONFIG_BLK_DEV_IDEDISK is not set
CONFIG_BLK_DEV_IDECD=m
CONFIG_BLK_DEV_IDETAPE=m
CONFIG_BLK_DEV_IDEFLOPPY=m
CONFIG_BLK_DEV_IDESCSI=m
# CONFIG_BLK_DEV_CMD640 is not set
# CONFIG_BLK_DEV_RZ1000 is not set
CONFIG_BLK_DEV_IDEPCI=y
# CONFIG_BLK_DEV_IDEDMA is not set
# CONFIG_BLK_DEV_OFFBOARD is not set
# CONFIG_IDE_CHIPSETS is not set
#
# Additional Block Devices
#
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_NBD=m
# CONFIG_BLK_DEV_MD is not set
# CONFIG_BLK_DEV_RAM is not set
CONFIG_BLK_DEV_XD=y
CONFIG_PARIDE_PARPORT=y
# CONFIG_PARIDE is not set
CONFIG_BLK_DEV_HD=y
#
# Networking options
#
CONFIG_PACKET=y
# CONFIG_NETLINK is not set
CONFIG_FIREWALL=y
# CONFIG_NET_ALIAS is not set
# CONFIG_FILTER is not set
# CONFIG_UNIX is not set
# CONFIG_INET is not set
#
#
#
CONFIG_IPX=y
CONFIG_IPX_INTERN=y
CONFIG_ATALK=m
#
# SCSI support
#
# CONFIG_SCSI is not set
#
# Network device support
#
CONFIG_NETDEVICES=y
CONFIG_ARCNET=y
CONFIG_ARCNET_ETH=y
CONFIG_ARCNET_1051=y
# CONFIG_ARCNET_COM90xx is not set
# CONFIG_ARCNET_COM90xxIO is not set
CONFIG_ARCNET_RIM_I=y
CONFIG_ARCNET_COM20020=y
# CONFIG_DUMMY is not set
# CONFIG_EQUALIZER is not set
CONFIG_NET_ETHERNET=y
CONFIG_NET_VENDOR_3COM=y
# CONFIG_EL1 is not set
CONFIG_EL2=y
CONFIG_ELPLUS=m
# CONFIG_EL3 is not set
# CONFIG_3C515 is not set
# CONFIG_VORTEX is not set
CONFIG_LANCE=y
# CONFIG_NET_VENDOR_SMC is not set
# CONFIG_NET_VENDOR_RACAL is not set
# CONFIG_NET_ISA is not set
CONFIG_NET_EISA=y
CONFIG_PCNET32=y
# CONFIG_APRICOT is not set
CONFIG_CS89x0=m
CONFIG_DE4X5=y
CONFIG_DEC_ELCP=y
CONFIG_DGRS=y
CONFIG_EEXPRESS_PRO100=m
CONFIG_NE2K_PCI=m
CONFIG_TLAN=y
CONFIG_VIA_RHINE=m
CONFIG_NET_POCKET=y
# CONFIG_ATP is not set
CONFIG_DE600=y
CONFIG_DE620=m
CONFIG_FDDI=y
# CONFIG_DEFXX is not set
CONFIG_DLCI=y
CONFIG_DLCI_COUNT=24
CONFIG_DLCI_MAX=8
CONFIG_SDLA=y
CONFIG_LTPC=m
# CONFIG_COPS is not set
# CONFIG_IPDDP is not set
CONFIG_PLIP=m
CONFIG_PPP=y
#
# CCP compressors for PPP are only built as modules.
#
# CONFIG_SLIP is not set
# CONFIG_NET_RADIO is not set
CONFIG_TR=y
CONFIG_IBMTR=m
# CONFIG_SKTR is not set
CONFIG_SMCTR=m
# CONFIG_HOSTESS_SV11 is not set
# CONFIG_COSA is not set
# CONFIG_WAN_DRIVERS is not set
# CONFIG_LAPBETHER is not set
CONFIG_X25_ASY=y
#
# Amateur Radio support
#
# CONFIG_HAMRADIO is not set
#
# ISDN subsystem
#
# CONFIG_ISDN is not set
#
# CD-ROM drivers (not for SCSI or IDE/ATAPI drives)
#
CONFIG_CD_NO_IDESCSI=y
CONFIG_AZTCD=m
CONFIG_GSCD=m
# CONFIG_SBPCD is not set
CONFIG_MCD=m
CONFIG_MCDX=m
# CONFIG_OPTCD is not set
CONFIG_CM206=y
CONFIG_SJCD=y
CONFIG_ISP16_CDI=m
# CONFIG_CDU31A is not set
# CONFIG_CDU535 is not set
#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_SERIAL=y
# CONFIG_SERIAL_CONSOLE is not set
CONFIG_SERIAL_EXTENDED=y
CONFIG_SERIAL_MANY_PORTS=y
# CONFIG_SERIAL_SHARE_IRQ is not set
CONFIG_SERIAL_DETECT_IRQ=y
CONFIG_SERIAL_MULTIPORT=y
# CONFIG_HUB6 is not set
# CONFIG_SERIAL_NONSTANDARD is not set
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256
# CONFIG_PRINTER is not set
CONFIG_MOUSE=y
CONFIG_ATIXL_BUSMOUSE=m
CONFIG_BUSMOUSE=y
CONFIG_MS_BUSMOUSE=m
CONFIG_PSMOUSE=y
# CONFIG_82C710_MOUSE is not set
CONFIG_PC110_PAD=y
CONFIG_QIC02_TAPE=y
# CONFIG_QIC02_DYNCONF is not set
#
# Edit configuration parameters in ./include/linux/tpqic02.h!
#
# CONFIG_WATCHDOG is not set
# CONFIG_RTC is not set
# CONFIG_VIDEO_DEV is not set
# CONFIG_NVRAM is not set
CONFIG_JOYSTICK=m
CONFIG_JOY_ANALOG=m
# CONFIG_JOY_ASSASIN is not set
# CONFIG_JOY_GRAVIS is not set
# CONFIG_JOY_LOGITECH is not set
CONFIG_JOY_SIDEWINDER=m
CONFIG_JOY_THRUSTMASTER=m
CONFIG_JOY_LIGHTNING=m
# CONFIG_JOY_CONSOLE is not set
# CONFIG_JOY_DB9 is not set
# CONFIG_JOY_TURBOGRAFX is not set
#
# Ftape, the floppy tape device driver
#
CONFIG_FTAPE=y
CONFIG_ZFTAPE=y
CONFIG_ZFT_DFLT_BLK_SZ=10240
#
# The compressor will be built as a module only!
#
CONFIG_ZFT_COMPRESSOR=m
# CONFIG_FT_PROC_FS is not set
CONFIG_FT_NORMAL_DEBUG=y
# CONFIG_FT_FULL_DEBUG is not set
# CONFIG_FT_NO_TRACE is not set
# CONFIG_FT_NO_TRACE_AT_ALL is not set
#
# Hardware configuration
#
CONFIG_FT_STD_FDC=y
# CONFIG_FT_MACH2 is not set
# CONFIG_FT_PROBE_FC10 is not set
# CONFIG_FT_ALT_FDC is not set
#
# ONLY for DEC Alpha architectures
#
CONFIG_FT_ALPHA_CLOCK=0
#
# Filesystems
#
# CONFIG_QUOTA is not set
# CONFIG_MINIX_FS is not set
# CONFIG_EXT2_FS is not set
CONFIG_ISO9660_FS=y
# CONFIG_JOLIET is not set
# CONFIG_FAT_FS is not set
# CONFIG_MSDOS_FS is not set
# CONFIG_UMSDOS_FS is not set
# CONFIG_VFAT_FS is not set
CONFIG_PROC_FS=y
# CONFIG_NCP_FS is not set
# CONFIG_HPFS_FS is not set
CONFIG_NTFS_FS=m
CONFIG_SYSV_FS=m
CONFIG_AFFS_FS=m
CONFIG_HFS_FS=y
CONFIG_ROMFS_FS=m
CONFIG_AUTOFS_FS=m
CONFIG_AMIGA_PARTITION=y
CONFIG_UFS_FS=m
CONFIG_BSD_DISKLABEL=y
# CONFIG_SMD_DISKLABEL is not set
CONFIG_SOLARIS_X86_PARTITION=y
# CONFIG_DEVPTS_FS is not set
CONFIG_MAC_PARTITION=y
CONFIG_NLS=y
#
# Native Language Support
#
CONFIG_NLS_CODEPAGE_437=y
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
CONFIG_NLS_CODEPAGE_850=y
CONFIG_NLS_CODEPAGE_852=m
# CONFIG_NLS_CODEPAGE_855 is not set
CONFIG_NLS_CODEPAGE_857=m
CONFIG_NLS_CODEPAGE_860=y
CONFIG_NLS_CODEPAGE_861=m
CONFIG_NLS_CODEPAGE_862=y
CONFIG_NLS_CODEPAGE_863=y
CONFIG_NLS_CODEPAGE_864=y
# CONFIG_NLS_CODEPAGE_865 is not set
CONFIG_NLS_CODEPAGE_866=y
CONFIG_NLS_CODEPAGE_869=m
CONFIG_NLS_CODEPAGE_874=m
# CONFIG_NLS_ISO8859_1 is not set
CONFIG_NLS_ISO8859_2=y
CONFIG_NLS_ISO8859_3=m
# CONFIG_NLS_ISO8859_4 is not set
CONFIG_NLS_ISO8859_5=m
CONFIG_NLS_ISO8859_6=m
CONFIG_NLS_ISO8859_7=y
# CONFIG_NLS_ISO8859_8 is not set
CONFIG_NLS_ISO8859_9=y
# CONFIG_NLS_KOI8_R is not set
#
# Console drivers
#
CONFIG_VGA_CONSOLE=y
# CONFIG_VIDEO_SELECT is not set
#
# Sound
#
# CONFIG_SOUND is not set
#
# Kernel hacking
#
# CONFIG_MAGIC_SYSRQ is not set
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/